summaryrefslogtreecommitdiff
path: root/lgc
diff options
context:
space:
mode:
authorWill Hawkins <[email protected]>2022-07-01 14:46:43 -0400
committerWill Hawkins <[email protected]>2022-07-01 14:47:19 -0400
commit793a53ece7fd16cd52735c12f47584c438e1a58b (patch)
tree7ee40d62a5b8d530b5fe12ed0c695a39855e45c5 /lgc
parent4fd7d42026f85da367afaaafeefd217b983f71ca (diff)
[Feature] Support spec v2 2/n
Diffstat (limited to 'lgc')
-rw-r--r--lgc/lgc.go18
1 files changed, 2 insertions, 16 deletions
diff --git a/lgc/lgc.go b/lgc/lgc.go
index b32721b..b0694db 100644
--- a/lgc/lgc.go
+++ b/lgc/lgc.go
@@ -279,14 +279,7 @@ func (lgd *LoadGeneratingConnectionDownload) Start(
)
}
- // Later, when the doDownload function attempts to add a tracer to the http request,
- // it will be associated with the context. Multiple tracers associated with the same
- // context will make it impossible to disambiguate the events. In other words, if there
- // are multiple tracers associated with the same context, *all* the tracers get invoked
- // every time that an event happens on a request with any of them! So, we will make a
- // unique context so that there is a one-to-one correspondence between tracers and requests.
- downloadCtx, _ := context.WithCancel(parentCtx)
- go lgd.doDownload(downloadCtx)
+ go lgd.doDownload(parentCtx)
return true
}
@@ -432,14 +425,7 @@ func (lgu *LoadGeneratingConnectionUpload) Start(
fmt.Printf("Started a load-generating upload (id: %v).\n", lgu.clientId)
}
- // Later, when the doUpload function attempts to add a tracer to the http request,
- // it will be associated with the context. Multiple tracers associated with the same
- // context will make it impossible to disambiguate the events. In other words, if there
- // are multiple tracers associated with the same context, *all* the tracers get invoked
- // every time that an event happens on a request with any of them! So, we will make a
- // unique context so that there is a one-to-one correspondence between tracers and requests.
- uploadCtx, _ := context.WithCancel(parentCtx)
- go lgu.doUpload(uploadCtx)
+ go lgu.doUpload(parentCtx)
return true
}