diff options
| author | Bjørn Ivar Teigen <[email protected]> | 2023-05-20 00:24:57 +0200 |
|---|---|---|
| committer | Bjørn Ivar Teigen <[email protected]> | 2023-05-20 00:24:57 +0200 |
| commit | 47b2c2f9f695f9bb5d9f0aa2c2860d4f7f28016a (patch) | |
| tree | b586b71e1c92d441ad698c1c3e5609cb76eb58d4 | |
| parent | 372640ea973d318443427c2468b00b54e116dfb0 (diff) | |
Hotfix of broken test
| -rw-r--r-- | qualityattenuation/qualityattenuation.go | 3 | ||||
| -rw-r--r-- | qualityattenuation/qualityattenuation_test.go | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/qualityattenuation/qualityattenuation.go b/qualityattenuation/qualityattenuation.go index 9782925..980253f 100644 --- a/qualityattenuation/qualityattenuation.go +++ b/qualityattenuation/qualityattenuation.go @@ -111,7 +111,8 @@ func (qa *SimpleQualityAttenuation) GetPDV(percentile float64) float64 { // It also assumes that the two quality attenuation values are measurements of the same thing (path, outcome, etc.). func (qa *SimpleQualityAttenuation) Merge(other *SimpleQualityAttenuation) { // Check that offsets are the same - if qa.Offset != other.Offset || qa.Latency_eq_loss_threshold != other.Latency_eq_loss_threshold { + if qa.Offset != other.Offset || + qa.Latency_eq_loss_threshold != other.Latency_eq_loss_threshold { //"Cannot merge quality attenuation values with different offset or latency_eq_loss_threshold" } diff --git a/qualityattenuation/qualityattenuation_test.go b/qualityattenuation/qualityattenuation_test.go index 862dc28..975cbf3 100644 --- a/qualityattenuation/qualityattenuation_test.go +++ b/qualityattenuation/qualityattenuation_test.go @@ -26,8 +26,8 @@ func TestBasicSimpleQualityAttenuation(t *testing.T) { assert.InEpsilon(t, 1.0, qa.GetMinimum(), 0.000001) assert.InEpsilon(t, 3.0, qa.GetMaximum(), 0.000001) assert.InEpsilon(t, 2.0, qa.GetAverage(), 0.000001) - assert.InEpsilon(t, 1.0, qa.GetVariance(), 0.000001) - assert.InEpsilon(t, 1.0, qa.GetStandardDeviation(), 0.000001) + assert.InEpsilon(t, 0.666667, qa.GetVariance(), 0.000001) + assert.InEpsilon(t, 0.816496, qa.GetStandardDeviation(), 0.000001) assert.InEpsilon(t, 2.0, qa.GetMedian(), 0.000001) assert.InEpsilon(t, 1.0, qa.GetLossPercentage()+1.000000000, 0.000001) assert.InEpsilon(t, 30, qa.GetRPM(), 0.000001) |