diff options
| author | Carlos Martín Nieto <[email protected]> | 2015-06-28 00:49:56 +0200 |
|---|---|---|
| committer | Carlos Martín Nieto <[email protected]> | 2015-06-28 00:49:56 +0200 |
| commit | ba0a24087a8cd1a354872c95f3efe0224ea84b4b (patch) | |
| tree | a10692688c9c91e1a190bbac87659029cfecc8ae | |
| parent | d400f1d5b2154f00f676b6b4e3c510f37de47573 (diff) | |
Get rid of Owner() on Remote and Submdoule
These are inherently unsafe. The underlying pointer might get released
at any moment.
| -rw-r--r-- | remote.go | 4 | ||||
| -rw-r--r-- | submodule.go | 6 |
2 files changed, 0 insertions, 10 deletions
@@ -421,10 +421,6 @@ func (repo *Repository) LookupRemote(name string) (*Remote, error) { return remote, nil } -func (o *Remote) Owner() Repository { - return Repository{C.git_remote_owner(o.ptr)} -} - func (o *Remote) Name() string { return C.GoString(C.git_remote_name(o.ptr)) } diff --git a/submodule.go b/submodule.go index fb7c5e6..971011b 100644 --- a/submodule.go +++ b/submodule.go @@ -158,12 +158,6 @@ func (sub *Submodule) AddToIndex(write_index bool) error { return nil } -func (sub *Submodule) Owner() *Repository { - repo := C.git_submodule_owner(sub.ptr) - //FIXME: how to handle dangling references ? - return &Repository{repo} -} - func (sub *Submodule) Name() string { n := C.git_submodule_name(sub.ptr) return C.GoString(n) |
