From ba0a24087a8cd1a354872c95f3efe0224ea84b4b Mon Sep 17 00:00:00 2001 From: Carlos Martín Nieto Date: Sun, 28 Jun 2015 00:49:56 +0200 Subject: Get rid of Owner() on Remote and Submdoule These are inherently unsafe. The underlying pointer might get released at any moment. --- remote.go | 4 ---- submodule.go | 6 ------ 2 files changed, 10 deletions(-) diff --git a/remote.go b/remote.go index a52ff06..4ff2040 100644 --- a/remote.go +++ b/remote.go @@ -421,10 +421,6 @@ func (repo *Repository) LookupRemote(name string) (*Remote, error) { return remote, nil } -func (o *Remote) Owner() Repository { - return Repository{C.git_remote_owner(o.ptr)} -} - func (o *Remote) Name() string { return C.GoString(C.git_remote_name(o.ptr)) } diff --git a/submodule.go b/submodule.go index fb7c5e6..971011b 100644 --- a/submodule.go +++ b/submodule.go @@ -158,12 +158,6 @@ func (sub *Submodule) AddToIndex(write_index bool) error { return nil } -func (sub *Submodule) Owner() *Repository { - repo := C.git_submodule_owner(sub.ptr) - //FIXME: how to handle dangling references ? - return &Repository{repo} -} - func (sub *Submodule) Name() string { n := C.git_submodule_name(sub.ptr) return C.GoString(n) -- cgit v1.2.3