summaryrefslogtreecommitdiff
path: root/gocomplete
diff options
context:
space:
mode:
authorEyal Posener <[email protected]>2017-05-19 00:11:30 +0300
committerEyal Posener <[email protected]>2017-05-19 00:15:33 +0300
commit3555a6948a991f57887ef2fef912b5479cefafcc (patch)
treebc394cea7d692f6985647c3ae2e5501800e598d3 /gocomplete
parentb3f5ec22d33ec8eda33606a6fc1406b8bce824ac (diff)
gocomplete: better pakcages listing
use go/build package only read one level of packages, and not all packages
Diffstat (limited to 'gocomplete')
-rw-r--r--gocomplete/pkgs.go72
1 files changed, 44 insertions, 28 deletions
diff --git a/gocomplete/pkgs.go b/gocomplete/pkgs.go
index e3a85d9..e8f5261 100644
--- a/gocomplete/pkgs.go
+++ b/gocomplete/pkgs.go
@@ -1,50 +1,66 @@
package main
import (
- "bytes"
- "encoding/json"
- "os/exec"
- "strings"
+ "go/build"
+ "io/ioutil"
+ "os"
+ "path/filepath"
"github.com/posener/complete"
)
-const goListFormat = `{"Name": "{{.Name}}", "Path": "{{.Dir}}", "FilesString": "{{.GoFiles}}"}`
-
func predictPackages(a complete.Args) (prediction []string) {
- dir := a.Directory()
- pkgs := listPackages(dir)
+ for {
+ prediction = complete.PredictFilesSet(listPackages(a)).Predict(a)
+
+ // if the number of prediction is not 1, we either have many results or
+ // have no results, so we return it.
+ if len(prediction) != 1 {
+ return
+ }
+
+ // if the result is only one item, we might want to recursively check
+ // for more accurate results.
+ if prediction[0] == a.Last {
+ return
+ }
+
+ // only try deeper, if the one item is a directory
+ if stat, err := os.Stat(prediction[0]); err != nil || !stat.IsDir() {
+ return
+ }
- files := make([]string, 0, len(pkgs))
- for _, p := range pkgs {
- files = append(files, p.Path)
+ a.Last = prediction[0]
}
- return complete.PredictFilesSet(files).Predict(a)
}
-type pack struct {
- Name string
- Path string
- FilesString string
- Files []string
-}
+func listPackages(a complete.Args) (dirctories []string) {
+ dir := a.Directory()
+ complete.Log("listing packages in %s", dir)
+ // import current directory
+ pkg, err := build.ImportDir(dir, 0)
+ if err != nil {
+ complete.Log("failed importing directory %s: %s", dir, err)
+ return
+ }
+ dirctories = append(dirctories, pkg.Dir)
-func listPackages(dir string) (pkgs []pack) {
- dir = strings.TrimRight(dir, "/") + "/..."
- out, err := exec.Command("go", "list", "-f", goListFormat, dir).Output()
+ // import subdirectories
+ files, err := ioutil.ReadDir(dir)
if err != nil {
+ complete.Log("failed reading directory %s: %s", dir, err)
return
}
- lines := bytes.Split(out, []byte("\n"))
- for _, line := range lines {
- var p pack
- err := json.Unmarshal(line, &p)
+ for _, f := range files {
+ if !f.IsDir() {
+ continue
+ }
+ pkg, err := build.ImportDir(filepath.Join(dir, f.Name()), 0)
if err != nil {
+ complete.Log("failed importing subdirectory %s: %s", filepath.Join(dir, f.Name()), err)
continue
}
- // parse the FileString from a string "[file1 file2 file3]" to a list of files
- p.Files = strings.Split(strings.Trim(p.FilesString, "[]"), " ")
- pkgs = append(pkgs, p)
+ dirctories = append(dirctories, pkg.Dir)
}
return
}