diff options
| author | Dave Collins <[email protected]> | 2016-09-07 11:21:46 -0500 |
|---|---|---|
| committer | Dave Collins <[email protected]> | 2016-09-07 12:06:01 -0500 |
| commit | 6d212800a42e8ab5c146b8ace3490ee17e5225f9 (patch) | |
| tree | 3f9e66d47d26d217cf8fc1c72ff093a582c342dc /spew | |
| parent | 66f99a29a08158b999b0dc2e7ccacf1131d4e0b4 (diff) | |
Deprecate "disableunsafe" tag in favor of "safe".
This adds a new build tag named "safe" which serves the exact same
purpose as the current "disableunsafe" tag. This is being done, as
recommended by @shurcooL, since it is emerging as the standard way to do
it in several high profile packages, it mirrors the "unsafe" package
nicely, it is shorter, and users generally seem to prefer it.
However, to avoid breaking existing infrastructure, the disableunsafe
tag is still available and simply is being deprecated.
Diffstat (limited to 'spew')
| -rw-r--r-- | spew/bypass.go | 5 | ||||
| -rw-r--r-- | spew/bypasssafe.go | 5 | ||||
| -rw-r--r-- | spew/config.go | 2 | ||||
| -rw-r--r-- | spew/internalunsafe_test.go | 5 |
4 files changed, 10 insertions, 7 deletions
diff --git a/spew/bypass.go b/spew/bypass.go index 1de6e02..d42a0bc 100644 --- a/spew/bypass.go +++ b/spew/bypass.go @@ -14,8 +14,9 @@ // NOTE: Due to the following build constraints, this file will only be compiled // when the code is not running on Google App Engine, compiled by GopherJS, and -// "-tags disableunsafe" is not added to the go build command line. -// +build !appengine,!disableunsafe,!js +// "-tags safe" is not added to the go build command line. The "disableunsafe" +// tag is deprecated and thus should not be used. +// +build !js,!appengine,!safe,!disableunsafe package spew diff --git a/spew/bypasssafe.go b/spew/bypasssafe.go index adef4c4..e47a4e7 100644 --- a/spew/bypasssafe.go +++ b/spew/bypasssafe.go @@ -14,8 +14,9 @@ // NOTE: Due to the following build constraints, this file will only be compiled // when the code is running on Google App Engine, compiled by GopherJS, or -// "-tags disableunsafe" is added to the go build command line. -// +build appengine disableunsafe js +// "-tags safe" is added to the go build command line. The "disableunsafe" +// tag is deprecated and thus should not be used. +// +build js appengine safe disableunsafe package spew diff --git a/spew/config.go b/spew/config.go index ee1ab07..5552827 100644 --- a/spew/config.go +++ b/spew/config.go @@ -64,7 +64,7 @@ type ConfigState struct { // inside these interface methods. As a result, this option relies on // access to the unsafe package, so it will not have any effect when // running in environments without access to the unsafe package such as - // Google App Engine or with the "disableunsafe" build tag specified. + // Google App Engine or with the "safe" build tag specified. DisablePointerMethods bool // ContinueOnMethod specifies whether or not recursion should continue once diff --git a/spew/internalunsafe_test.go b/spew/internalunsafe_test.go index ddaa41d..863b62c 100644 --- a/spew/internalunsafe_test.go +++ b/spew/internalunsafe_test.go @@ -14,8 +14,9 @@ // NOTE: Due to the following build constraints, this file will only be compiled // when the code is not running on Google App Engine, compiled by GopherJS, and -// "-tags disableunsafe" is not added to the go build command line. -// +build !appengine,!disableunsafe,!js +// "-tags safe" is not added to the go build command line. The "disableunsafe" +// tag is deprecated and thus should not be used. +// +build !js,!appengine,!safe,!disableunsafe /* This test file is part of the spew package rather than than the spew_test |