diff options
| author | Will Hawkins <[email protected]> | 2021-12-16 00:38:05 -0500 |
|---|---|---|
| committer | Will Hawkins <[email protected]> | 2021-12-16 00:38:05 -0500 |
| commit | bb48aa9f23d3b74aa3e31f395deaf6fdd1618391 (patch) | |
| tree | ddaf9901e191e42011fd80ad76a5c5035bb41280 /networkQuality.go | |
| parent | c24e70fd98bb61ddf735a7f54e278258f2dfc990 (diff) | |
Bugfix: Incorrect AllSequentialIncreasesLessThan (nee IncreasesLessThan) Calculation
In AllSequentialIncreasesLessThan (nee IncreasesLessThan), an earlier
version of this function did not properly take into account the order
in which values were added to the moving average when calculating
the percent change. This patch fixes that error and adds an additional
criteria for the function to return `true`: there must be *at least*
`intervals` collected samples.
Diffstat (limited to 'networkQuality.go')
| -rw-r--r-- | networkQuality.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/networkQuality.go b/networkQuality.go index 54c4260..e052e1f 100644 --- a/networkQuality.go +++ b/networkQuality.go @@ -242,7 +242,7 @@ func saturate(saturationCtx context.Context, operatingCtx context.Context, lbcGe fmt.Printf("%v: Network reached saturation with current flow count.\n", debug) } // If new flows added and for 4 seconds the moving average throughput did not change: network reached stable saturation - if (currentIteration-previousFlowIncreaseIteration) < 4 && movingAverageAverage.IncreasesLessThan(float64(5)) { + if (currentIteration-previousFlowIncreaseIteration) < 4 && movingAverageAverage.AllSequentialIncreasesLessThan(float64(5)) { if debug != nil { fmt.Printf("%v: New flows added within the last four seconds and the moving-average average is consistent!\n", debug) } |