[Bugfix] Continue Adding LGCs During Responsiveness Stabilization

The client was not continuing to add load-generating connections at each
stability-check interval (as called for by the spec).

Also, the client now properly obeys the `--rpm.id` option given on the
command line.

Signed-off-by: Will Hawkins <[email protected]>

1 files changed, 1 insertions, 7 deletions

diff --git a/networkQuality.go b/networkQuality.go
index 355e1b3..f22cc32 100644
--- a/networkQuality.go
+++ b/networkQuality.go
@@ -686,18 +686,15 @@ func main() {
 			throughputCtx, throughputCtxCancel := context.WithCancel(operatingCtx)
 			direction.ThroughputActivityCtx, direction.ThroughputActivityCtxCancel = &throughputCtx, &throughputCtxCancel
 
-			reachWorkingConditionsCtx, reachWorkingConditionsCtxCancel :=
-				context.WithCancel(throughputOperatorCtx)
-
 			lgStabilizationCommunicationChannel := rpm.LoadGenerator(
 				throughputOperatorCtx,
 				*direction.ThroughputActivityCtx,
-				reachWorkingConditionsCtx,
 				specParameters.EvalInterval,
 				direction.CreateLgdc,
 				&direction.Lgcc,
 				&globalNumericBucketGenerator,
 				specParameters.MaxParallelConns,
+				specParameters.EvalInterval,
 				*calculateExtendedStats,
 				direction.DirectionDebugging,
 			)
@@ -812,9 +809,6 @@ func main() {
 				)
 			}
 
-			// No matter what, we will stop adding additional load-generating connections!
-			reachWorkingConditionsCtxCancel()
-
 			direction.SelfRtts = series.NewWindowSeries[float64, uint64](series.Forever, 0)
 			direction.ForeignRtts = series.NewWindowSeries[float64, uint64](series.Forever, 0)