1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
|
/**
* @license
* Copyright 2025 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
import { openBrowserSecurely } from './secure-browser-launcher.js';
// Create mock function using vi.hoisted
const mockExecFile = vi.hoisted(() => vi.fn());
// Mock modules
vi.mock('node:child_process');
vi.mock('node:util', () => ({
promisify: () => mockExecFile,
}));
describe('secure-browser-launcher', () => {
let originalPlatform: PropertyDescriptor | undefined;
beforeEach(() => {
vi.clearAllMocks();
mockExecFile.mockResolvedValue({ stdout: '', stderr: '' });
originalPlatform = Object.getOwnPropertyDescriptor(process, 'platform');
});
afterEach(() => {
if (originalPlatform) {
Object.defineProperty(process, 'platform', originalPlatform);
}
});
function setPlatform(platform: string) {
Object.defineProperty(process, 'platform', {
value: platform,
configurable: true,
});
}
describe('URL validation', () => {
it('should allow valid HTTP URLs', async () => {
setPlatform('darwin');
await openBrowserSecurely('http://example.com');
expect(mockExecFile).toHaveBeenCalledWith(
'open',
['http://example.com'],
expect.any(Object),
);
});
it('should allow valid HTTPS URLs', async () => {
setPlatform('darwin');
await openBrowserSecurely('https://example.com');
expect(mockExecFile).toHaveBeenCalledWith(
'open',
['https://example.com'],
expect.any(Object),
);
});
it('should reject non-HTTP(S) protocols', async () => {
await expect(openBrowserSecurely('file:///etc/passwd')).rejects.toThrow(
'Unsafe protocol',
);
await expect(openBrowserSecurely('javascript:alert(1)')).rejects.toThrow(
'Unsafe protocol',
);
await expect(openBrowserSecurely('ftp://example.com')).rejects.toThrow(
'Unsafe protocol',
);
});
it('should reject invalid URLs', async () => {
await expect(openBrowserSecurely('not-a-url')).rejects.toThrow(
'Invalid URL',
);
await expect(openBrowserSecurely('')).rejects.toThrow('Invalid URL');
});
it('should reject URLs with control characters', async () => {
await expect(
openBrowserSecurely('http://example.com\nmalicious-command'),
).rejects.toThrow('invalid characters');
await expect(
openBrowserSecurely('http://example.com\rmalicious-command'),
).rejects.toThrow('invalid characters');
await expect(
openBrowserSecurely('http://example.com\x00'),
).rejects.toThrow('invalid characters');
});
});
describe('Command injection prevention', () => {
it('should prevent PowerShell command injection on Windows', async () => {
setPlatform('win32');
// The POC from the vulnerability report
const maliciousUrl =
"http://127.0.0.1:8080/?param=example#$(Invoke-Expression([System.Text.Encoding]::UTF8.GetString([System.Convert]::FromBase64String('Y2FsYy5leGU='))))";
await openBrowserSecurely(maliciousUrl);
// Verify that execFile was called (not exec) and the URL is passed safely
expect(mockExecFile).toHaveBeenCalledWith(
'powershell.exe',
[
'-NoProfile',
'-NonInteractive',
'-WindowStyle',
'Hidden',
'-Command',
`Start-Process '${maliciousUrl.replace(/'/g, "''")}'`,
],
expect.any(Object),
);
});
it('should handle URLs with special shell characters safely', async () => {
setPlatform('darwin');
const urlsWithSpecialChars = [
'http://example.com/path?param=value&other=$value',
'http://example.com/path#fragment;command',
'http://example.com/$(whoami)',
'http://example.com/`command`',
'http://example.com/|pipe',
'http://example.com/>redirect',
];
for (const url of urlsWithSpecialChars) {
await openBrowserSecurely(url);
// Verify the URL is passed as an argument, not interpreted by shell
expect(mockExecFile).toHaveBeenCalledWith(
'open',
[url],
expect.any(Object),
);
}
});
it('should properly escape single quotes in URLs on Windows', async () => {
setPlatform('win32');
const urlWithSingleQuotes =
"http://example.com/path?name=O'Brien&test='value'";
await openBrowserSecurely(urlWithSingleQuotes);
// Verify that single quotes are escaped by doubling them
expect(mockExecFile).toHaveBeenCalledWith(
'powershell.exe',
[
'-NoProfile',
'-NonInteractive',
'-WindowStyle',
'Hidden',
'-Command',
`Start-Process 'http://example.com/path?name=O''Brien&test=''value'''`,
],
expect.any(Object),
);
});
});
describe('Platform-specific behavior', () => {
it('should use correct command on macOS', async () => {
setPlatform('darwin');
await openBrowserSecurely('https://example.com');
expect(mockExecFile).toHaveBeenCalledWith(
'open',
['https://example.com'],
expect.any(Object),
);
});
it('should use PowerShell on Windows', async () => {
setPlatform('win32');
await openBrowserSecurely('https://example.com');
expect(mockExecFile).toHaveBeenCalledWith(
'powershell.exe',
expect.arrayContaining([
'-Command',
`Start-Process 'https://example.com'`,
]),
expect.any(Object),
);
});
it('should use xdg-open on Linux', async () => {
setPlatform('linux');
await openBrowserSecurely('https://example.com');
expect(mockExecFile).toHaveBeenCalledWith(
'xdg-open',
['https://example.com'],
expect.any(Object),
);
});
it('should throw on unsupported platforms', async () => {
setPlatform('aix');
await expect(openBrowserSecurely('https://example.com')).rejects.toThrow(
'Unsupported platform',
);
});
});
describe('Error handling', () => {
it('should handle browser launch failures gracefully', async () => {
setPlatform('darwin');
mockExecFile.mockRejectedValueOnce(new Error('Command not found'));
await expect(openBrowserSecurely('https://example.com')).rejects.toThrow(
'Failed to open browser',
);
});
it('should try fallback browsers on Linux', async () => {
setPlatform('linux');
// First call to xdg-open fails
mockExecFile.mockRejectedValueOnce(new Error('Command not found'));
// Second call to gnome-open succeeds
mockExecFile.mockResolvedValueOnce({ stdout: '', stderr: '' });
await openBrowserSecurely('https://example.com');
expect(mockExecFile).toHaveBeenCalledTimes(2);
expect(mockExecFile).toHaveBeenNthCalledWith(
1,
'xdg-open',
['https://example.com'],
expect.any(Object),
);
expect(mockExecFile).toHaveBeenNthCalledWith(
2,
'gnome-open',
['https://example.com'],
expect.any(Object),
);
});
});
});
|
