summaryrefslogtreecommitdiff
path: root/packages/cli/src
diff options
context:
space:
mode:
Diffstat (limited to 'packages/cli/src')
-rw-r--r--packages/cli/src/config/settingsSchema.test.ts2
-rw-r--r--packages/cli/src/config/settingsSchema.ts2
-rw-r--r--packages/cli/src/utils/settingsUtils.test.ts8
3 files changed, 6 insertions, 6 deletions
diff --git a/packages/cli/src/config/settingsSchema.test.ts b/packages/cli/src/config/settingsSchema.test.ts
index 118b1823..43bf52c9 100644
--- a/packages/cli/src/config/settingsSchema.test.ts
+++ b/packages/cli/src/config/settingsSchema.test.ts
@@ -187,7 +187,7 @@ describe('SettingsSchema', () => {
expect(SETTINGS_SCHEMA.hideWindowTitle.showInDialog).toBe(true);
expect(SETTINGS_SCHEMA.hideTips.showInDialog).toBe(true);
expect(SETTINGS_SCHEMA.hideBanner.showInDialog).toBe(true);
- expect(SETTINGS_SCHEMA.usageStatisticsEnabled.showInDialog).toBe(true);
+ expect(SETTINGS_SCHEMA.usageStatisticsEnabled.showInDialog).toBe(false);
// Check that advanced settings are hidden from dialog
expect(SETTINGS_SCHEMA.selectedAuthType.showInDialog).toBe(false);
diff --git a/packages/cli/src/config/settingsSchema.ts b/packages/cli/src/config/settingsSchema.ts
index 01f73c68..4a7a986b 100644
--- a/packages/cli/src/config/settingsSchema.ts
+++ b/packages/cli/src/config/settingsSchema.ts
@@ -103,7 +103,7 @@ export const SETTINGS_SCHEMA = {
requiresRestart: true,
default: true,
description: 'Enable collection of usage statistics',
- showInDialog: true,
+ showInDialog: false, // All details are shown in /privacy and dependent on auth type
},
autoConfigureMaxOldSpaceSize: {
type: 'boolean',
diff --git a/packages/cli/src/utils/settingsUtils.test.ts b/packages/cli/src/utils/settingsUtils.test.ts
index 98a4588c..39c611f8 100644
--- a/packages/cli/src/utils/settingsUtils.test.ts
+++ b/packages/cli/src/utils/settingsUtils.test.ts
@@ -239,7 +239,7 @@ describe('SettingsUtils', () => {
expect(shouldShowInDialog('showMemoryUsage')).toBe(true);
expect(shouldShowInDialog('vimMode')).toBe(true);
expect(shouldShowInDialog('hideWindowTitle')).toBe(true);
- expect(shouldShowInDialog('usageStatisticsEnabled')).toBe(true);
+ expect(shouldShowInDialog('usageStatisticsEnabled')).toBe(false);
});
it('should return false for settings marked to hide from dialog', () => {
@@ -286,7 +286,7 @@ describe('SettingsUtils', () => {
expect(allKeys).toContain('ideMode');
expect(allKeys).toContain('disableAutoUpdate');
expect(allKeys).toContain('showMemoryUsage');
- expect(allKeys).toContain('usageStatisticsEnabled');
+ expect(allKeys).not.toContain('usageStatisticsEnabled');
expect(allKeys).not.toContain('selectedAuthType');
expect(allKeys).not.toContain('coreTools');
expect(allKeys).not.toContain('theme'); // Now hidden
@@ -302,7 +302,7 @@ describe('SettingsUtils', () => {
expect(keys).toContain('showMemoryUsage');
expect(keys).toContain('vimMode');
expect(keys).toContain('hideWindowTitle');
- expect(keys).toContain('usageStatisticsEnabled');
+ expect(keys).not.toContain('usageStatisticsEnabled');
expect(keys).not.toContain('selectedAuthType'); // Advanced setting
expect(keys).not.toContain('useExternalAuth'); // Advanced setting
});
@@ -329,7 +329,7 @@ describe('SettingsUtils', () => {
expect(dialogKeys).toContain('showMemoryUsage');
expect(dialogKeys).toContain('vimMode');
expect(dialogKeys).toContain('hideWindowTitle');
- expect(dialogKeys).toContain('usageStatisticsEnabled');
+ expect(dialogKeys).not.toContain('usageStatisticsEnabled');
expect(dialogKeys).toContain('ideMode');
expect(dialogKeys).toContain('disableAutoUpdate');