summaryrefslogtreecommitdiff
path: root/packages
diff options
context:
space:
mode:
authorJerop Kipruto <[email protected]>2025-06-23 20:29:31 -0400
committerGitHub <[email protected]>2025-06-24 00:29:31 +0000
commitaca034fdfec0ec29bdb47c5feaa4eafd6e68fac7 (patch)
tree137496d8b1d3394e6ceeb7ccdd8e06ccdef301e8 /packages
parentb3741f7016a6b32ebdc5a9b5203191fc04910d3a (diff)
Refactor usage statistics to be a top-level setting (#1363)
This commit refactors the `usageStatisticsEnabled` setting from a sub-property of the `telemetry` configuration to a top-level setting. This change simplifies the configuration by decoupling usage statistics from the telemetry settings. The documentation has also been updated to reflect this change.
Diffstat (limited to 'packages')
-rw-r--r--packages/cli/src/config/config.ts3
-rw-r--r--packages/cli/src/config/settings.ts1
-rw-r--r--packages/core/src/config/config.ts7
3 files changed, 6 insertions, 5 deletions
diff --git a/packages/cli/src/config/config.ts b/packages/cli/src/config/config.ts
index 4e5b0008..7f957245 100644
--- a/packages/cli/src/config/config.ts
+++ b/packages/cli/src/config/config.ts
@@ -226,9 +226,8 @@ export async function loadCliConfig(
process.env.OTEL_EXPORTER_OTLP_ENDPOINT ??
settings.telemetry?.otlpEndpoint,
logPrompts: argv.telemetryLogPrompts ?? settings.telemetry?.logPrompts,
- usageStatisticsEnabled:
- settings.telemetry?.usageStatisticsEnabled ?? true,
},
+ usageStatisticsEnabled: settings.usageStatisticsEnabled ?? true,
// Git-aware file filtering settings
fileFiltering: {
respectGitIgnore: settings.fileFiltering?.respectGitIgnore,
diff --git a/packages/cli/src/config/settings.ts b/packages/cli/src/config/settings.ts
index b149216a..882df403 100644
--- a/packages/cli/src/config/settings.ts
+++ b/packages/cli/src/config/settings.ts
@@ -49,6 +49,7 @@ export interface Settings {
contextFileName?: string | string[];
accessibility?: AccessibilitySettings;
telemetry?: TelemetrySettings;
+ usageStatisticsEnabled?: boolean;
preferredEditor?: string;
bugCommand?: BugCommandSettings;
checkpointing?: CheckpointingSettings;
diff --git a/packages/core/src/config/config.ts b/packages/core/src/config/config.ts
index 65d69a41..a92dd7ba 100644
--- a/packages/core/src/config/config.ts
+++ b/packages/core/src/config/config.ts
@@ -57,7 +57,6 @@ export interface TelemetrySettings {
target?: TelemetryTarget;
otlpEndpoint?: string;
logPrompts?: boolean;
- usageStatisticsEnabled?: boolean;
}
export class MCPServerConfig {
@@ -107,6 +106,7 @@ export interface ConfigParameters {
contextFileName?: string | string[];
accessibility?: AccessibilitySettings;
telemetry?: TelemetrySettings;
+ usageStatisticsEnabled?: boolean;
fileFiltering?: {
respectGitIgnore?: boolean;
enableRecursiveFileSearch?: boolean;
@@ -142,6 +142,7 @@ export class Config {
private readonly showMemoryUsage: boolean;
private readonly accessibility: AccessibilitySettings;
private readonly telemetrySettings: TelemetrySettings;
+ private readonly usageStatisticsEnabled: boolean;
private geminiClient!: GeminiClient;
private readonly fileFiltering: {
respectGitIgnore: boolean;
@@ -181,8 +182,8 @@ export class Config {
target: params.telemetry?.target ?? DEFAULT_TELEMETRY_TARGET,
otlpEndpoint: params.telemetry?.otlpEndpoint ?? DEFAULT_OTLP_ENDPOINT,
logPrompts: params.telemetry?.logPrompts ?? true,
- usageStatisticsEnabled: params.telemetry?.usageStatisticsEnabled ?? true,
};
+ this.usageStatisticsEnabled = params.usageStatisticsEnabled ?? true;
this.fileFiltering = {
respectGitIgnore: params.fileFiltering?.respectGitIgnore ?? true,
@@ -386,7 +387,7 @@ export class Config {
}
getUsageStatisticsEnabled(): boolean {
- return this.telemetrySettings.usageStatisticsEnabled ?? true;
+ return this.usageStatisticsEnabled;
}
getExtensionContextFilePaths(): string[] {