diff options
| author | Anas H. Sulaiman <[email protected]> | 2025-06-13 12:00:38 -0400 |
|---|---|---|
| committer | GitHub <[email protected]> | 2025-06-13 12:00:38 -0400 |
| commit | 34e0d9c0b65b91b12df4f205d9835e05913992b9 (patch) | |
| tree | 50f503a89ecdc74e2c13ad59aab18c89dd027573 /packages/core/src | |
| parent | c886f085256684a121a016e7ee2280131eeebbfc (diff) | |
cleanup unused `allowBuildArtifacts` (#1010)
Diffstat (limited to 'packages/core/src')
| -rw-r--r-- | packages/core/src/config/config.test.ts | 3 | ||||
| -rw-r--r-- | packages/core/src/config/config.ts | 9 | ||||
| -rw-r--r-- | packages/core/src/telemetry/loggers.test.ts | 2 | ||||
| -rw-r--r-- | packages/core/src/telemetry/loggers.ts | 2 | ||||
| -rw-r--r-- | packages/core/src/telemetry/types.ts | 1 | ||||
| -rw-r--r-- | packages/core/src/tools/glob.test.ts | 1 | ||||
| -rw-r--r-- | packages/core/src/tools/read-many-files.test.ts | 1 |
7 files changed, 0 insertions, 19 deletions
diff --git a/packages/core/src/config/config.test.ts b/packages/core/src/config/config.test.ts index 71af832b..4a5cae1b 100644 --- a/packages/core/src/config/config.test.ts +++ b/packages/core/src/config/config.test.ts @@ -106,18 +106,15 @@ describe('Server Config (config.ts)', () => { it('should set default file filtering settings when not provided', () => { const config = new Config(baseParams); expect(config.getFileFilteringRespectGitIgnore()).toBe(true); - expect(config.getFileFilteringAllowBuildArtifacts()).toBe(false); }); it('should set custom file filtering settings when provided', () => { const paramsWithFileFiltering: ConfigParameters = { ...baseParams, fileFilteringRespectGitIgnore: false, - fileFilteringAllowBuildArtifacts: true, }; const config = new Config(paramsWithFileFiltering); expect(config.getFileFilteringRespectGitIgnore()).toBe(false); - expect(config.getFileFilteringAllowBuildArtifacts()).toBe(true); }); it('Config constructor should set telemetry to true when provided as true', () => { diff --git a/packages/core/src/config/config.ts b/packages/core/src/config/config.ts index 5e13241d..2576080b 100644 --- a/packages/core/src/config/config.ts +++ b/packages/core/src/config/config.ts @@ -81,7 +81,6 @@ export interface ConfigParameters { telemetryLogUserPromptsEnabled?: boolean; telemetryOtlpEndpoint?: string; fileFilteringRespectGitIgnore?: boolean; - fileFilteringAllowBuildArtifacts?: boolean; checkpoint?: boolean; proxy?: string; cwd: string; @@ -114,7 +113,6 @@ export class Config { private readonly geminiClient: GeminiClient; private readonly geminiIgnorePatterns: string[] = []; private readonly fileFilteringRespectGitIgnore: boolean; - private readonly fileFilteringAllowBuildArtifacts: boolean; private fileDiscoveryService: FileDiscoveryService | null = null; private gitService: GitService | undefined = undefined; private readonly checkpoint: boolean; @@ -148,8 +146,6 @@ export class Config { this.telemetryOtlpEndpoint = params.telemetryOtlpEndpoint ?? ''; this.fileFilteringRespectGitIgnore = params.fileFilteringRespectGitIgnore ?? true; - this.fileFilteringAllowBuildArtifacts = - params.fileFilteringAllowBuildArtifacts ?? false; this.checkpoint = params.checkpoint ?? false; this.proxy = params.proxy; this.cwd = params.cwd ?? process.cwd(); @@ -296,10 +292,6 @@ export class Config { return this.fileFilteringRespectGitIgnore; } - getFileFilteringAllowBuildArtifacts(): boolean { - return this.fileFilteringAllowBuildArtifacts; - } - getCheckpointEnabled(): boolean { return this.checkpoint; } @@ -317,7 +309,6 @@ export class Config { this.fileDiscoveryService = new FileDiscoveryService(this.targetDir); await this.fileDiscoveryService.initialize({ respectGitIgnore: this.fileFilteringRespectGitIgnore, - includeBuildArtifacts: this.fileFilteringAllowBuildArtifacts, }); } return this.fileDiscoveryService; diff --git a/packages/core/src/telemetry/loggers.test.ts b/packages/core/src/telemetry/loggers.test.ts index 58ea3a10..2f909c22 100644 --- a/packages/core/src/telemetry/loggers.test.ts +++ b/packages/core/src/telemetry/loggers.test.ts @@ -62,7 +62,6 @@ describe('loggers', () => { }), getTelemetryLogUserPromptsEnabled: () => true, getFileFilteringRespectGitIgnore: () => true, - getFileFilteringAllowBuildArtifacts: () => false, getDebugMode: () => true, getMcpServers: () => ({ 'test-server': { @@ -90,7 +89,6 @@ describe('loggers', () => { code_assist_enabled: false, log_user_prompts_enabled: true, file_filtering_respect_git_ignore: true, - file_filtering_allow_build_artifacts: false, debug_mode: true, mcp_servers: 'test-server', }, diff --git a/packages/core/src/telemetry/loggers.ts b/packages/core/src/telemetry/loggers.ts index f6896def..e788119c 100644 --- a/packages/core/src/telemetry/loggers.ts +++ b/packages/core/src/telemetry/loggers.ts @@ -89,8 +89,6 @@ export function logCliConfiguration(config: Config): void { log_user_prompts_enabled: config.getTelemetryLogUserPromptsEnabled(), file_filtering_respect_git_ignore: config.getFileFilteringRespectGitIgnore(), - file_filtering_allow_build_artifacts: - config.getFileFilteringAllowBuildArtifacts(), debug_mode: config.getDebugMode(), mcp_servers: mcpServers ? Object.keys(mcpServers).join(',') : '', }; diff --git a/packages/core/src/telemetry/types.ts b/packages/core/src/telemetry/types.ts index bed9b16d..68dd411e 100644 --- a/packages/core/src/telemetry/types.ts +++ b/packages/core/src/telemetry/types.ts @@ -67,7 +67,6 @@ export interface CliConfigEvent { vertex_ai_enabled: boolean; log_user_prompts_enabled: boolean; file_filtering_respect_git_ignore: boolean; - file_filtering_allow_build_artifacts: boolean; } export type TelemetryEvent = diff --git a/packages/core/src/tools/glob.test.ts b/packages/core/src/tools/glob.test.ts index b848b030..21f7f0fe 100644 --- a/packages/core/src/tools/glob.test.ts +++ b/packages/core/src/tools/glob.test.ts @@ -26,7 +26,6 @@ describe('GlobTool', () => { return service; }, getFileFilteringRespectGitIgnore: () => true, - getFileFilteringAllowBuildArtifacts: () => false, } as Partial<Config> as Config; beforeEach(async () => { diff --git a/packages/core/src/tools/read-many-files.test.ts b/packages/core/src/tools/read-many-files.test.ts index 82f6c57d..90a5a312 100644 --- a/packages/core/src/tools/read-many-files.test.ts +++ b/packages/core/src/tools/read-many-files.test.ts @@ -29,7 +29,6 @@ describe('ReadManyFilesTool', () => { return service; }, getFileFilteringRespectGitIgnore: () => true, - getFileFilteringAllowBuildArtifacts: () => false, getGeminiIgnorePatterns: () => ['**/foo.bar', 'foo.baz', 'foo.*'], } as Partial<Config> as Config; |
