diff options
| author | matt korwel <[email protected]> | 2025-07-09 21:51:37 -0700 |
|---|---|---|
| committer | GitHub <[email protected]> | 2025-07-09 21:51:37 -0700 |
| commit | 58607b92dfe76dd657338b5433d0fd33800f9272 (patch) | |
| tree | 4a07182ca01f20074a5544db5caf5a198cabae6c /packages/core/src/utils/user_id.test.ts | |
| parent | b7f8e1360fc13c077c24c98fe9d85e0734195000 (diff) | |
Revert "fix: Use Email for Clearcut Logging and Refactor User Info Fetching" (#3744)
Diffstat (limited to 'packages/core/src/utils/user_id.test.ts')
| -rw-r--r-- | packages/core/src/utils/user_id.test.ts | 26 |
1 files changed, 16 insertions, 10 deletions
diff --git a/packages/core/src/utils/user_id.test.ts b/packages/core/src/utils/user_id.test.ts index 42d8958c..185d6c95 100644 --- a/packages/core/src/utils/user_id.test.ts +++ b/packages/core/src/utils/user_id.test.ts @@ -5,7 +5,7 @@ */ import { describe, it, expect } from 'vitest'; -import { getInstallationId, getGoogleAccountEmail } from './user_id.js'; +import { getInstallationId, getGoogleAccountId } from './user_id.js'; describe('user_id', () => { describe('getInstallationId', () => { @@ -22,24 +22,30 @@ describe('user_id', () => { }); }); - describe('getGoogleAccountEmail', () => { - it('should return a non-empty string', () => { - const result = getGoogleAccountEmail(); + describe('getGoogleAccountId', () => { + it('should return a non-empty string', async () => { + const result = await getGoogleAccountId(); expect(result).toBeDefined(); expect(typeof result).toBe('string'); // Should be consistent on subsequent calls - const secondCall = getGoogleAccountEmail(); + const secondCall = await getGoogleAccountId(); expect(secondCall).toBe(result); }); - it('should return empty string when no Google Account email is cached', () => { - // In a clean test environment, there should be no cached Google Account email - const googleAccountEmailResult = getGoogleAccountEmail(); + it('should return empty string when no Google Account ID is cached, or a valid ID when cached', async () => { + // The function can return either an empty string (if no cached ID) or a valid Google Account ID (if cached) + const googleAccountIdResult = await getGoogleAccountId(); - // They should be the same when no Google Account email is cached - expect(googleAccountEmailResult).toBe(''); + expect(googleAccountIdResult).toBeDefined(); + expect(typeof googleAccountIdResult).toBe('string'); + + // Should be either empty string or a numeric string (Google Account ID) + if (googleAccountIdResult !== '') { + // If we have a cached ID, it should be a numeric string + expect(googleAccountIdResult).toMatch(/^\d+$/); + } }); }); }); |
