summaryrefslogtreecommitdiff
path: root/packages/cli/src/ui
diff options
context:
space:
mode:
authorOlcan <[email protected]>2025-06-08 21:52:11 -0700
committerGitHub <[email protected]>2025-06-08 21:52:11 -0700
commita2fee6bdd3927a2a08520ab87dabc8fecdb6075b (patch)
tree90f80f532a6faa524ef10ab9e38aabc5731a3684 /packages/cli/src/ui
parenta3d11e8fef23f466abec7a8a5f400cbc30a6c5fb (diff)
fix mcp timeouts and missing description on mcp errors (#868)
Diffstat (limited to 'packages/cli/src/ui')
-rw-r--r--packages/cli/src/ui/hooks/useReactToolScheduler.ts6
-rw-r--r--packages/cli/src/ui/hooks/useToolScheduler.test.ts13
2 files changed, 5 insertions, 14 deletions
diff --git a/packages/cli/src/ui/hooks/useReactToolScheduler.ts b/packages/cli/src/ui/hooks/useReactToolScheduler.ts
index ae58ed38..8dbcfb87 100644
--- a/packages/cli/src/ui/hooks/useReactToolScheduler.ts
+++ b/packages/cli/src/ui/hooks/useReactToolScheduler.ts
@@ -249,10 +249,8 @@ export function mapToDisplay(
trackedCall.request.args,
);
renderOutputAsMarkdown = currentToolInstance.isOutputMarkdown;
- }
-
- if (trackedCall.status === 'error') {
- description = '';
+ } else if ('request' in trackedCall && 'args' in trackedCall.request) {
+ description = JSON.stringify(trackedCall.request.args);
}
const baseDisplayProperties: Omit<
diff --git a/packages/cli/src/ui/hooks/useToolScheduler.test.ts b/packages/cli/src/ui/hooks/useToolScheduler.test.ts
index f5a3529c..8e3f139b 100644
--- a/packages/cli/src/ui/hooks/useToolScheduler.test.ts
+++ b/packages/cli/src/ui/hooks/useToolScheduler.test.ts
@@ -924,7 +924,7 @@ describe('mapToDisplay', () => {
expectedStatus: ToolCallStatus.Error,
expectedResultDisplay: 'Error display tool not found',
expectedName: baseRequest.name,
- expectedDescription: '',
+ expectedDescription: JSON.stringify(baseRequest.args),
},
{
name: 'error tool execution failed',
@@ -940,7 +940,7 @@ describe('mapToDisplay', () => {
expectedStatus: ToolCallStatus.Error,
expectedResultDisplay: 'Execution failed display',
expectedName: baseTool.displayName, // Changed from baseTool.name
- expectedDescription: '',
+ expectedDescription: baseTool.getDescription(baseRequest.args),
},
{
name: 'cancelled',
@@ -986,14 +986,7 @@ describe('mapToDisplay', () => {
expect(toolDisplay.resultDisplay).toBe(expectedResultDisplay);
expect(toolDisplay.name).toBe(expectedName);
-
- if (status === 'error' && !extraProps?.tool) {
- expect(toolDisplay.description).toBe('');
- } else {
- expect(toolDisplay.description).toBe(
- expectedDescription ?? baseTool.getDescription(baseRequest.args),
- );
- }
+ expect(toolDisplay.description).toBe(expectedDescription);
expect(toolDisplay.renderOutputAsMarkdown).toBe(
extraProps?.tool?.isOutputMarkdown ?? false,