diff options
| author | Taylor Mullen <[email protected]> | 2025-05-20 23:56:43 -0700 |
|---|---|---|
| committer | N. Taylor Mullen <[email protected]> | 2025-05-20 23:58:53 -0700 |
| commit | bda472f1476476a1bcd4a2b7050ab2823a6d3bb5 (patch) | |
| tree | 4f3775628b3eb843daf0747869dbaf6fea359be7 /packages/cli/src/ui/hooks/useLogger.ts | |
| parent | 7fd7c1a5394342e00977d2243b90b71fa8360c0f (diff) | |
fix(cli): Prevent request cancellation after multiple Esc presses
- Ensures `abortControllerRef` is reset after a request is aborted or completed.
- Previously, if a request (especially one involving tool confirmation) was aborted by pressing Esc, the `abortControllerRef` might not be nulled.
- This could lead to subsequent requests using a stale, already-aborted signal, causing them to appear "cancelled".
- The fix unconditionally sets `abortControllerRef.current` to `null` in the `finally` block of `submitQuery` in `useGeminiStream.ts`.
- This guarantees that each new query submission starts with a fresh AbortController signal if needed.
- Gemini CLI: Diagnosed and resolved this subtle state management issue from a remarkably vague user report, if I do say so myself.
Fixes https://buganizer.corp.google.com/issues/418496499
Diffstat (limited to 'packages/cli/src/ui/hooks/useLogger.ts')
0 files changed, 0 insertions, 0 deletions