diff options
| author | Taylor Mullen <[email protected]> | 2025-04-20 22:10:23 -0400 |
|---|---|---|
| committer | N. Taylor Mullen <[email protected]> | 2025-04-20 22:13:55 -0400 |
| commit | 63f864cdd79a0357ec1e0474586fb00a0ec7d91b (patch) | |
| tree | 4f70dd65b2cd0eef5e147fa514488ba259a327e6 /packages/cli/src/ui/hooks/useGeminiStream.ts | |
| parent | c095091853b70affdd9cf2cc6cc590451c658c1f (diff) | |
Fix read-file from exploding with path not found error.
- There were a few hiccups here. Somehow 2.5-flash wasn't actually abiding by our tool schema. Instead it was inferring `path`. To semi-combat this I've renamed `file_path` -> `path`.
- We weren't elevating errors that were created via schema validation. Instead both the `glob` and `read-file.ts` now surface this.
- In error scenarios (like failing schema) we were improperly surfacing these as success cases because we were overriding tool status.
Diffstat (limited to 'packages/cli/src/ui/hooks/useGeminiStream.ts')
| -rw-r--r-- | packages/cli/src/ui/hooks/useGeminiStream.ts | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/packages/cli/src/ui/hooks/useGeminiStream.ts b/packages/cli/src/ui/hooks/useGeminiStream.ts index 6e3e8e84..21a9f508 100644 --- a/packages/cli/src/ui/hooks/useGeminiStream.ts +++ b/packages/cli/src/ui/hooks/useGeminiStream.ts @@ -330,7 +330,13 @@ export const useGeminiStream = ( ...item, tools: item.tools.map((tool) => tool.callId === callId - ? { ...tool, status: ToolCallStatus.Invoked } + ? { + ...tool, + status: + tool.status === ToolCallStatus.Error + ? ToolCallStatus.Error + : ToolCallStatus.Invoked, + } : tool, ), }; @@ -362,7 +368,10 @@ export const useGeminiStream = ( tool.callId === callId ? { ...tool, - status: ToolCallStatus.Success, + status: + tool.status === ToolCallStatus.Error + ? ToolCallStatus.Error + : ToolCallStatus.Success, resultDisplay: result.returnDisplay, } : tool, |