summaryrefslogtreecommitdiff
path: root/packages/cli/src/ui/hooks/useGeminiStream.ts
diff options
context:
space:
mode:
authorN. Taylor Mullen <[email protected]>2025-06-08 11:14:45 -0700
committerGitHub <[email protected]>2025-06-08 11:14:45 -0700
commit241c404573a8dd8c032dde5478a9bec95dd83a19 (patch)
tree7b0f6e812a19dfe1dbe09254781af605c370d12f /packages/cli/src/ui/hooks/useGeminiStream.ts
parent9efca40dae2e75477af1a20df4e3e65bf8dfe93d (diff)
fix(cli): correctly handle tool invocation cancellation (#844)
Diffstat (limited to 'packages/cli/src/ui/hooks/useGeminiStream.ts')
-rw-r--r--packages/cli/src/ui/hooks/useGeminiStream.ts46
1 files changed, 44 insertions, 2 deletions
diff --git a/packages/cli/src/ui/hooks/useGeminiStream.ts b/packages/cli/src/ui/hooks/useGeminiStream.ts
index 5e741547..3b3d01e0 100644
--- a/packages/cli/src/ui/hooks/useGeminiStream.ts
+++ b/packages/cli/src/ui/hooks/useGeminiStream.ts
@@ -19,7 +19,7 @@ import {
ToolCallRequestInfo,
logUserPrompt,
} from '@gemini-cli/core';
-import { type PartListUnion } from '@google/genai';
+import { type Part, type PartListUnion } from '@google/genai';
import {
StreamingState,
HistoryItemWithoutId,
@@ -531,6 +531,41 @@ export const useGeminiStream = (
completedAndReadyToSubmitTools.length > 0 &&
completedAndReadyToSubmitTools.length === toolCalls.length
) {
+ // If all the tools were cancelled, don't submit a response to Gemini.
+ const allToolsCancelled = completedAndReadyToSubmitTools.every(
+ (tc) => tc.status === 'cancelled',
+ );
+
+ if (allToolsCancelled) {
+ if (geminiClient) {
+ // We need to manually add the function responses to the history
+ // so the model knows the tools were cancelled.
+ const responsesToAdd = completedAndReadyToSubmitTools.flatMap(
+ (toolCall) => toolCall.response.responseParts,
+ );
+ for (const response of responsesToAdd) {
+ let parts: Part[];
+ if (Array.isArray(response)) {
+ parts = response;
+ } else if (typeof response === 'string') {
+ parts = [{ text: response }];
+ } else {
+ parts = [response];
+ }
+ geminiClient.addHistory({
+ role: 'user',
+ parts,
+ });
+ }
+ }
+
+ const callIdsToMarkAsSubmitted = completedAndReadyToSubmitTools.map(
+ (toolCall) => toolCall.request.callId,
+ );
+ markToolsAsSubmitted(callIdsToMarkAsSubmitted);
+ return;
+ }
+
const responsesToSend: PartListUnion[] =
completedAndReadyToSubmitTools.map(
(toolCall) => toolCall.response.responseParts,
@@ -542,7 +577,14 @@ export const useGeminiStream = (
markToolsAsSubmitted(callIdsToMarkAsSubmitted);
submitQuery(mergePartListUnions(responsesToSend));
}
- }, [toolCalls, isResponding, submitQuery, markToolsAsSubmitted, addItem]);
+ }, [
+ toolCalls,
+ isResponding,
+ submitQuery,
+ markToolsAsSubmitted,
+ addItem,
+ geminiClient,
+ ]);
const pendingHistoryItems = [
pendingHistoryItemRef.current,