diff options
| author | Taylor Mullen <[email protected]> | 2025-04-21 14:32:18 -0400 |
|---|---|---|
| committer | N. Taylor Mullen <[email protected]> | 2025-04-21 14:47:17 -0400 |
| commit | 738c2692fb9bdeda7c801e7b4e773f81ebc1ded0 (patch) | |
| tree | 5647ea34e0c18d790b54d7e5f2663a18688823cc /packages/cli/src/ui/components/messages/ToolMessage.tsx | |
| parent | 618f8a43cf9402aba7d441341a46a229c92502dd (diff) | |
Fix confirmations.
- This fixes what it means to get confirmations in GC. Prior to this they had just been accidentally unwired as part of all of the refactorings to turns + to server/core.
- The key piece of this is that we wrap the onConfirm in the gemini stream hook in order to resubmit function responses. This isn't 100% ideal but gets the job done for now.
- Fixed history not updating properly with confirmations.
Fixes https://b.corp.google.com/issues/412323656
Diffstat (limited to 'packages/cli/src/ui/components/messages/ToolMessage.tsx')
| -rw-r--r-- | packages/cli/src/ui/components/messages/ToolMessage.tsx | 34 |
1 files changed, 0 insertions, 34 deletions
diff --git a/packages/cli/src/ui/components/messages/ToolMessage.tsx b/packages/cli/src/ui/components/messages/ToolMessage.tsx index f33ed6cb..f21e1d28 100644 --- a/packages/cli/src/ui/components/messages/ToolMessage.tsx +++ b/packages/cli/src/ui/components/messages/ToolMessage.tsx @@ -11,11 +11,6 @@ import { IndividualToolCallDisplay, ToolCallStatus } from '../../types.js'; import { DiffRenderer } from './DiffRenderer.js'; import { FileDiff, ToolResultDisplay } from '../../../tools/tools.js'; import { Colors } from '../../colors.js'; -import { - ToolCallConfirmationDetails, - ToolEditConfirmationDetails, - ToolExecuteConfirmationDetails, -} from '@gemini-code/server'; export const ToolMessage: React.FC<IndividualToolCallDisplay> = ({ callId, @@ -23,12 +18,7 @@ export const ToolMessage: React.FC<IndividualToolCallDisplay> = ({ description, resultDisplay, status, - confirmationDetails, }) => { - // Explicitly type the props to help the type checker - const typedConfirmationDetails = confirmationDetails as - | ToolCallConfirmationDetails - | undefined; const typedResultDisplay = resultDisplay as ToolResultDisplay | undefined; let color = Colors.SubtleComment; @@ -78,30 +68,6 @@ export const ToolMessage: React.FC<IndividualToolCallDisplay> = ({ : ` - ${description}`} </Text> </Box> - {status === ToolCallStatus.Confirming && typedConfirmationDetails && ( - <Box flexDirection="column" marginLeft={2}> - {/* Display diff for edit/write */} - {'fileDiff' in typedConfirmationDetails && ( - <DiffRenderer - diffContent={ - (typedConfirmationDetails as ToolEditConfirmationDetails) - .fileDiff - } - /> - )} - {/* Display command for execute */} - {'command' in typedConfirmationDetails && ( - <Text color={Colors.AccentYellow}> - Command:{' '} - { - (typedConfirmationDetails as ToolExecuteConfirmationDetails) - .command - } - </Text> - )} - {/* <ConfirmInput onConfirm={handleConfirm} isFocused={isFocused} /> */} - </Box> - )} {status === ToolCallStatus.Success && typedResultDisplay && ( <Box flexDirection="column" marginLeft={2}> {typeof typedResultDisplay === 'string' ? ( |
