diff options
| author | Taylor Mullen <[email protected]> | 2025-05-19 16:11:45 -0700 |
|---|---|---|
| committer | N. Taylor Mullen <[email protected]> | 2025-05-19 16:16:47 -0700 |
| commit | 323b1298f91c7fe86f5108f8dd369b71ad81a146 (patch) | |
| tree | 874f5dc7ea98fd78672f93add3c190dfc582e1ee /packages/cli/src/ui/App.tsx | |
| parent | a756489f861ad58cddf67f9bfb84251d82d09169 (diff) | |
fix: Ensure user written `!` is treated opaquely if not in shell mode\n\n- Addresses an issue where commands prefixed with `!` (e.g., `!ls`) were incorrectly handled by the shell command processor if the `!` was added after initially typing the command.\n- Ensures that such commands are correctly forwarded to the Gemini model.\n- Updates `useGeminiStream` to be aware of shell mode to properly manage streaming state.\n\nFixes https://buganizer.corp.google.com/issues/418761305
Diffstat (limited to 'packages/cli/src/ui/App.tsx')
| -rw-r--r-- | packages/cli/src/ui/App.tsx | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/packages/cli/src/ui/App.tsx b/packages/cli/src/ui/App.tsx index 30944046..befefec1 100644 --- a/packages/cli/src/ui/App.tsx +++ b/packages/cli/src/ui/App.tsx @@ -145,6 +145,7 @@ export const App = ({ config, setDebugMessage, handleSlashCommand, + shellModeActive, ); const { elapsedTime, currentLoadingPhrase } = useLoadingIndicator(streamingState); @@ -154,16 +155,10 @@ export const App = ({ (submittedValue: string) => { const trimmedValue = submittedValue.trim(); if (trimmedValue.length > 0) { - if (shellModeActive && !trimmedValue.startsWith('!')) { - // TODO: Don't prefix (hack) and properly submit pass throughs to a dedicated hook: - // https://b.corp.google.com/issues/418509745 - submitQuery(`!${trimmedValue}`); - } else { - submitQuery(trimmedValue); - } + submitQuery(trimmedValue); } }, - [submitQuery, shellModeActive], + [submitQuery], ); const userMessages = useMemo( |
