summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnas H. Sulaiman <[email protected]>2025-06-13 11:49:48 -0400
committerGitHub <[email protected]>2025-06-13 11:49:48 -0400
commitc886f085256684a121a016e7ee2280131eeebbfc (patch)
tree8287ebd8447325f6066e6c3e84d5a5d8f2f5c6cf
parentd25459d8153e1a35e0e0175447f9c624978d6a51 (diff)
cleanup unused `customIgnorePatterns` (#1009)
-rw-r--r--docs/cli/configuration.md2
-rw-r--r--packages/cli/src/ui/hooks/atCommandProcessor.test.ts2
-rw-r--r--packages/cli/src/ui/hooks/useCompletion.integration.test.ts2
-rw-r--r--packages/core/src/tools/glob.test.ts1
-rw-r--r--packages/core/src/tools/read-many-files.test.ts1
5 files changed, 2 insertions, 6 deletions
diff --git a/docs/cli/configuration.md b/docs/cli/configuration.md
index 606c06fd..cd8d26c4 100644
--- a/docs/cli/configuration.md
+++ b/docs/cli/configuration.md
@@ -49,13 +49,11 @@ When you create a `.gemini/settings.json` file for project-specific settings, or
- **Description:** Controls git-aware file filtering behavior for @ commands and file discovery tools.
- **Properties:**
- **`respectGitIgnore`** (boolean, default: `true`): Whether to respect .gitignore patterns when discovering files. When enabled, git-ignored files (like `node_modules/`, `dist/`, `.env`) are automatically excluded from @ commands and file listing operations.
- - **`customIgnorePatterns`** (array of strings, default: `[]`): Additional patterns to ignore beyond git-ignored files. Useful for excluding specific directories or file types.
- **`allowBuildArtifacts`** (boolean, default: `false`): Whether to include build artifacts and generated files in file discovery operations.
- **Example:**
```json
"fileFiltering": {
"respectGitIgnore": true,
- "customIgnorePatterns": ["temp/", "*.log"],
"allowBuildArtifacts": false
}
```
diff --git a/packages/cli/src/ui/hooks/atCommandProcessor.test.ts b/packages/cli/src/ui/hooks/atCommandProcessor.test.ts
index 3ae9a4c1..c76bdd37 100644
--- a/packages/cli/src/ui/hooks/atCommandProcessor.test.ts
+++ b/packages/cli/src/ui/hooks/atCommandProcessor.test.ts
@@ -92,7 +92,7 @@ describe('handleAtCommand', () => {
initialize: vi.fn(),
shouldIgnoreFile: vi.fn(() => false),
filterFiles: vi.fn((files) => files),
- getIgnoreInfo: vi.fn(() => ({ gitIgnored: [], customIgnored: [] })),
+ getIgnoreInfo: vi.fn(() => ({ gitIgnored: [] })),
isGitRepository: vi.fn(() => true),
};
vi.mocked(FileDiscoveryService).mockImplementation(
diff --git a/packages/cli/src/ui/hooks/useCompletion.integration.test.ts b/packages/cli/src/ui/hooks/useCompletion.integration.test.ts
index 020e0ea9..76204497 100644
--- a/packages/cli/src/ui/hooks/useCompletion.integration.test.ts
+++ b/packages/cli/src/ui/hooks/useCompletion.integration.test.ts
@@ -41,7 +41,7 @@ describe('useCompletion git-aware filtering integration', () => {
initialize: vi.fn(),
shouldIgnoreFile: vi.fn(),
filterFiles: vi.fn(),
- getIgnoreInfo: vi.fn(() => ({ gitIgnored: [], customIgnored: [] })),
+ getIgnoreInfo: vi.fn(() => ({ gitIgnored: [] })),
glob: vi.fn().mockResolvedValue([]),
};
diff --git a/packages/core/src/tools/glob.test.ts b/packages/core/src/tools/glob.test.ts
index 37738ba7..b848b030 100644
--- a/packages/core/src/tools/glob.test.ts
+++ b/packages/core/src/tools/glob.test.ts
@@ -26,7 +26,6 @@ describe('GlobTool', () => {
return service;
},
getFileFilteringRespectGitIgnore: () => true,
- getFileFilteringCustomIgnorePatterns: () => [],
getFileFilteringAllowBuildArtifacts: () => false,
} as Partial<Config> as Config;
diff --git a/packages/core/src/tools/read-many-files.test.ts b/packages/core/src/tools/read-many-files.test.ts
index eb647c18..82f6c57d 100644
--- a/packages/core/src/tools/read-many-files.test.ts
+++ b/packages/core/src/tools/read-many-files.test.ts
@@ -29,7 +29,6 @@ describe('ReadManyFilesTool', () => {
return service;
},
getFileFilteringRespectGitIgnore: () => true,
- getFileFilteringCustomIgnorePatterns: () => [],
getFileFilteringAllowBuildArtifacts: () => false,
getGeminiIgnorePatterns: () => ['**/foo.bar', 'foo.baz', 'foo.*'],
} as Partial<Config> as Config;