summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShardul Natu <[email protected]>2025-08-21 00:25:42 -0700
committerGitHub <[email protected]>2025-08-21 07:25:42 +0000
commit0242ecd83a5b0673a6ef97a406a743b286ef12e2 (patch)
treeb63d688bba9ae1db18ea1b146dd4bf3926004404
parentf8f79bf2f772e27ffe4af968679137b734a92dd3 (diff)
fix(metrics): Do not convert numerical metrics to strings (#6701)
Co-authored-by: Shnatu <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Bryan Morgan <[email protected]> Co-authored-by: Arya Gummadi <[email protected]>
-rw-r--r--packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts6
-rw-r--r--packages/core/src/telemetry/loggers.test.ts2
-rw-r--r--packages/core/src/telemetry/types.ts10
3 files changed, 9 insertions, 9 deletions
diff --git a/packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts b/packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts
index 32dcf926..dd506bf0 100644
--- a/packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts
+++ b/packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts
@@ -385,12 +385,14 @@ export class ClearcutLogger {
{
gemini_cli_key:
EventMetadataKey.GEMINI_CLI_START_SESSION_MCP_SERVERS_COUNT,
- value: event.mcp_servers_count ? event.mcp_servers_count : '',
+ value: event.mcp_servers_count
+ ? event.mcp_servers_count.toString()
+ : '',
},
{
gemini_cli_key:
EventMetadataKey.GEMINI_CLI_START_SESSION_MCP_TOOLS_COUNT,
- value: event.mcp_tools_count ? event.mcp_tools_count : '',
+ value: event.mcp_tools_count?.toString() ?? '',
},
{
gemini_cli_key: EventMetadataKey.GEMINI_CLI_START_SESSION_MCP_TOOLS,
diff --git a/packages/core/src/telemetry/loggers.test.ts b/packages/core/src/telemetry/loggers.test.ts
index d52cb600..a3375d95 100644
--- a/packages/core/src/telemetry/loggers.test.ts
+++ b/packages/core/src/telemetry/loggers.test.ts
@@ -162,7 +162,7 @@ describe('loggers', () => {
file_filtering_respect_git_ignore: true,
debug_mode: true,
mcp_servers: 'test-server',
- mcp_servers_count: '1',
+ mcp_servers_count: 1,
mcp_tools: undefined,
mcp_tools_count: undefined,
},
diff --git a/packages/core/src/telemetry/types.ts b/packages/core/src/telemetry/types.ts
index 8b1b5d68..9310992c 100644
--- a/packages/core/src/telemetry/types.ts
+++ b/packages/core/src/telemetry/types.ts
@@ -39,8 +39,8 @@ export class StartSessionEvent implements BaseTelemetryEvent {
telemetry_enabled: boolean;
telemetry_log_user_prompts_enabled: boolean;
file_filtering_respect_git_ignore: boolean;
- mcp_servers_count?: string;
- mcp_tools_count?: string;
+ mcp_servers_count: number;
+ mcp_tools_count?: number;
mcp_tools?: string;
constructor(config: Config, toolRegistry?: ToolRegistry) {
@@ -70,14 +70,12 @@ export class StartSessionEvent implements BaseTelemetryEvent {
config.getTelemetryLogPromptsEnabled();
this.file_filtering_respect_git_ignore =
config.getFileFilteringRespectGitIgnore();
- this.mcp_servers_count = mcpServers
- ? Object.keys(mcpServers).length.toString()
- : '';
+ this.mcp_servers_count = mcpServers ? Object.keys(mcpServers).length : 0;
if (toolRegistry) {
const mcpTools = toolRegistry
.getAllTools()
.filter((tool) => tool instanceof DiscoveredMCPTool);
- this.mcp_tools_count = mcpTools.length.toString();
+ this.mcp_tools_count = mcpTools.length;
this.mcp_tools = mcpTools
.map((tool) => (tool as DiscoveredMCPTool).name)
.join(',');