summaryrefslogtreecommitdiff
path: root/.vscode
diff options
context:
space:
mode:
authorJacob Richman <[email protected]>2025-05-24 00:44:17 -0700
committerGitHub <[email protected]>2025-05-24 00:44:17 -0700
commitb4c16d1f56f4e19fffd3d7608b410570f35045f9 (patch)
treedfda3634f4d266f5472bd37b78362abebe6a9c9e /.vscode
parent1c3d9d7623ecff0437db0627cace0cbb421b458a (diff)
Code review comment fixes and some refactors. (#525)
No intentional different behavior aside for tweaks suggested from the code review of #506 Refactor: Extract console message logic to custom hook This commit refactors the console message handling from App.tsx into a new custom hook useConsoleMessages. This change improves the testability of the console message logic and declutters the main App component. Created useConsoleMessages.ts to encapsulate console message state and update logic. Updated App.tsx to utilize the new useConsoleMessages hook. Added unit tests for useConsoleMessages.ts to ensure its functionality. I deleted and started over on LoadingIndicator.test.tsx as I spent way too much time trying to fix it before just regenerating the tests as the code was easier to write tests for from scratch and the existing tests were not that good (I added them in the previous pull request).
Diffstat (limited to '.vscode')
-rw-r--r--.vscode/launch.json40
1 files changed, 40 insertions, 0 deletions
diff --git a/.vscode/launch.json b/.vscode/launch.json
index 5a7c6522..b7976fd6 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -82,6 +82,46 @@
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen",
"skipFiles": ["<node_internals>/**"]
+ },
+ {
+ "type": "node",
+ "request": "launch",
+ "name": "Debug useLoadingIndicator Test (CLI)",
+ "runtimeExecutable": "npm",
+ "runtimeArgs": [
+ "run",
+ "test",
+ "-w",
+ "packages/cli",
+ "--",
+ "--inspect-brk=9229",
+ "--no-file-parallelism",
+ "${workspaceFolder}/packages/cli/src/ui/hooks/useLoadingIndicator.test.ts"
+ ],
+ "cwd": "${workspaceFolder}",
+ "console": "integratedTerminal",
+ "internalConsoleOptions": "neverOpen",
+ "skipFiles": ["<node_internals>/**"]
+ },
+ {
+ "type": "node",
+ "request": "launch",
+ "name": "Debug LoadingIndicator Test (CLI)",
+ "runtimeExecutable": "npm",
+ "runtimeArgs": [
+ "run",
+ "test",
+ "-w",
+ "packages/cli",
+ "--",
+ "--inspect-brk=9229",
+ "--no-file-parallelism",
+ "${workspaceFolder}/packages/cli/src/ui/components/LoadingIndicator.test.tsx"
+ ],
+ "cwd": "${workspaceFolder}",
+ "console": "integratedTerminal",
+ "internalConsoleOptions": "neverOpen",
+ "skipFiles": ["<node_internals>/**"]
}
]
}