| Age | Commit message (Collapse) | Author |
|---|
|
We need to compare against the number zero, not its ASCII value.
|
|
Go already has all the necessary pieces for encoding and decoding hex
strings. Using them let's us avoid going into C land.
Benchmarks show this takes about half the time as using libgit2's
functions.
|
|
This is not needed. We can do id[:] to get a slice.
|
|
This is the most common way of having an id that's not in Oid form, so
let's make it the "default" and rename to NewOidFromBytes() the one that
takes []byte.
|
|
There is no need for a struct with a single field. An Oid is 20 bytes
which hold the binary representation of the hash, so let's use that
directly. Go lets us have methods on this new type just the same.
|
|
|
|
|
|
On top: fix git_buf handling and rename signature
This fixes #57, #54.
Conflicts:
git.go
reference.go
repository.go
submodule.go
|
|
|
|
|
|
The library stores error information in thread-local storage, which
means we need to make sure that the Go runtime doesn't switch OS
threads between the time we call a function and th time we attempt to
retrieve the error information.
|
|
Don't name the return values, as they conflict with the names we want
inside and the types don't match what we want to have inside. We need
them to be two-way channels in the function, and then pass
unidirectional references to the different functions.
|
|
Catch nil error instances
|
|
Implement a reference iterator
|
|
Wrap the reference iterators, and provide a Iter() function to get
them through a channel.
|
|
|
|
Unfortunately libgit2 sometimes returns an error without setting an
error message. Provide an alternative message instead of trying to
dereference nil.
|
|
|
|
|
|
|
|
Some calls like Reference.Target() can return NULL if the reference is
symbolic. Make sure newOidFromC() can handle these situations.
|
|
|
