diff options
| author | Carlos MartÃn Nieto <[email protected]> | 2019-01-03 16:22:15 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2019-01-03 16:22:15 +0100 |
| commit | fc1230ba16d8f2af3c5e74c4c5b84970f33f1b19 (patch) | |
| tree | 1f37e8d052327ae0b1a78689899e3c59b4c015f2 /odb.go | |
| parent | e319b9427fec099fcc8986d49a61f66ae1133e0f (diff) | |
| parent | bdca40d27558337f2aa84856b0dd8c6b1b6bb5c8 (diff) | |
Merge pull request #447 from walkenzoy/master
git2go: small fixes to odb module
Diffstat (limited to 'odb.go')
| -rw-r--r-- | odb.go | 26 |
1 files changed, 18 insertions, 8 deletions
@@ -81,15 +81,19 @@ func (v *Odb) Exists(oid *Oid) bool { func (v *Odb) Write(data []byte, otype ObjectType) (oid *Oid, err error) { oid = new(Oid) - var cptr unsafe.Pointer - if len(data) > 0 { - cptr = unsafe.Pointer(&data[0]) - } runtime.LockOSThread() defer runtime.UnlockOSThread() - ret := C.git_odb_write(oid.toC(), v.ptr, cptr, C.size_t(len(data)), C.git_otype(otype)) + var size C.size_t + if len(data) > 0 { + size = C.size_t(len(data)) + } else { + data = []byte{0} + size = C.size_t(0) + } + + ret := C.git_odb_write(oid.toC(), v.ptr, unsafe.Pointer(&data[0]), size, C.git_otype(otype)) runtime.KeepAlive(v) if ret < 0 { return nil, MakeGitError(ret) @@ -165,13 +169,19 @@ func (v *Odb) ForEach(callback OdbForEachCallback) error { // Hash determines the object-ID (sha1) of a data buffer. func (v *Odb) Hash(data []byte, otype ObjectType) (oid *Oid, err error) { oid = new(Oid) - header := (*reflect.SliceHeader)(unsafe.Pointer(&data)) - ptr := unsafe.Pointer(header.Data) runtime.LockOSThread() defer runtime.UnlockOSThread() - ret := C.git_odb_hash(oid.toC(), ptr, C.size_t(header.Len), C.git_otype(otype)) + var size C.size_t + if len(data) > 0 { + size = C.size_t(len(data)) + } else { + data = []byte{0} + size = C.size_t(0) + } + + ret := C.git_odb_hash(oid.toC(), unsafe.Pointer(&data[0]), size, C.git_otype(otype)) runtime.KeepAlive(data) if ret < 0 { return nil, MakeGitError(ret) |
