summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Steinhardt <[email protected]>2015-04-24 10:13:52 +0200
committerPatrick Steinhardt <[email protected]>2015-05-22 09:02:24 +0200
commit83f9e6a7053cae61cf835221b3a61bdeb2e528f4 (patch)
tree49a53b824049802c9dc4015d4e70ff5e77264f6d
parentfe902f56a8545df76b51458b21aa84916ab51f6c (diff)
blob: use HandleList for C function callbacks.
-rw-r--r--blob.go15
1 files changed, 12 insertions, 3 deletions
diff --git a/blob.go b/blob.go
index 5a33bd8..b1fc78a 100644
--- a/blob.go
+++ b/blob.go
@@ -60,8 +60,13 @@ type BlobCallbackData struct {
}
//export blobChunkCb
-func blobChunkCb(buffer *C.char, maxLen C.size_t, payload unsafe.Pointer) int {
- data := (*BlobCallbackData)(payload)
+func blobChunkCb(buffer *C.char, maxLen C.size_t, handle unsafe.Pointer) int {
+ payload := pointerHandles.Get(handle)
+ data, ok := payload.(*BlobCallbackData)
+ if !ok {
+ panic("could not retrieve blob callback data")
+ }
+
goBuf, err := data.Callback(int(maxLen))
if err == io.EOF {
return 0
@@ -83,8 +88,12 @@ func (repo *Repository) CreateBlobFromChunks(hintPath string, callback BlobChunk
defer C.free(unsafe.Pointer(chintPath))
}
oid := C.git_oid{}
+
payload := &BlobCallbackData{Callback: callback}
- ecode := C._go_git_blob_create_fromchunks(&oid, repo.ptr, chintPath, unsafe.Pointer(payload))
+ handle := pointerHandles.Track(payload)
+ defer pointerHandles.Untrack(handle)
+
+ ecode := C._go_git_blob_create_fromchunks(&oid, repo.ptr, chintPath, handle)
if payload.Error != nil {
return nil, payload.Error
}