diff options
Diffstat (limited to 'generateAppend.go')
| -rw-r--r-- | generateAppend.go | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/generateAppend.go b/generateAppend.go index 4c2dda6..d011ea9 100644 --- a/generateAppend.go +++ b/generateAppend.go @@ -14,7 +14,7 @@ import ( func (msg *MsgName) simpleAppend(w io.Writer, FRUIT, APPLES, APPLE string) string { LOCK := msg.getLockname("x") - funcdef := "func (x *" + FRUIT + ") Append(y *" + APPLE + ") *" + APPLE + funcdef := "func (x *" + FRUIT + ") Append(y *" + APPLE + ")" // log.Printf("\t\t(x %s) APPEND(%s)\n", FRUIT, APPLE) // append -- no check at all @@ -23,10 +23,12 @@ func (msg *MsgName) simpleAppend(w io.Writer, FRUIT, APPLES, APPLE string) strin fmt.Fprintln(w, " "+LOCK+".Lock()") fmt.Fprintln(w, " defer "+LOCK+".Unlock()") fmt.Fprintln(w, "") - fmt.Fprintln(w, " z := proto.Clone(y).(*"+APPLE+")") - fmt.Fprintln(w, " x."+APPLES+" = append(x."+APPLES+", z)") + fmt.Fprintln(w, " // append was doing Clone() and that was poorly named.") + fmt.Fprintln(w, " // now autogenpb makes Clone() for that") + fmt.Fprintln(w, " // z := proto.Clone(y).(*"+APPLE+")") + fmt.Fprintln(w, " x."+APPLES+" = append(x."+APPLES+", y)") fmt.Fprintln(w, "") - fmt.Fprintln(w, " return z") + fmt.Fprintln(w, " // return z") fmt.Fprintln(w, "}") fmt.Fprintln(w, "") @@ -51,7 +53,10 @@ func (msg *MsgName) simpleAppendBy(w io.Writer, STRUCT, FUNCNAME, STRUCTVAR, VAR fmt.Fprintln(w, " }") fmt.Fprintln(w, " }") fmt.Fprintln(w, "") - fmt.Fprintln(w, " x."+STRUCTVAR+" = append(x."+STRUCTVAR+", proto.Clone(y).(*"+VARTYPE+"))") + fmt.Fprintln(w, " // append was doing Clone() and that was poorly named.") + fmt.Fprintln(w, " // now autogenpb makes Clone() for that") + fmt.Fprintln(w, " // x."+STRUCTVAR+" = append(x."+STRUCTVAR+", proto.Clone(y).(*"+VARTYPE+"))") + fmt.Fprintln(w, " x."+STRUCTVAR+" = append(x."+STRUCTVAR+", y)") fmt.Fprintln(w, " return true") fmt.Fprintln(w, "}") fmt.Fprintln(w, "") |