merge with latest

1 files changed, 25 insertions, 20 deletions

diff --git a/submodule.go b/submodule.go
index 48ea151..a94afd4 100644
--- a/submodule.go
+++ b/submodule.go
@@ -56,6 +56,14 @@ const (
 	SubmoduleStatusWdUntracked                     = C.GIT_SUBMODULE_STATUS_WD_UNTRACKED
 )
 
+type SubmoduleRecurse int
+
+const (
+	SubmoduleRecurseNo       SubmoduleRecurse = C.GIT_SUBMODULE_RECURSE_NO
+	SubmoduleRecurseYes                       = C.GIT_SUBMODULE_RECURSE_YES
+	SubmoduleRecurseOndemand                  = C.GIT_SUBMODULE_RECURSE_ONDEMAND
+)
+
 func SubmoduleStatusIsUnmodified(status int) bool {
 	o := SubmoduleStatus(status) & ^(SubmoduleStatusInHead | SubmoduleStatusInIndex |
 		SubmoduleStatusInConfig | SubmoduleStatusInWd)
@@ -73,7 +81,7 @@ func (repo *Repository) LookupSubmodule(name string) (*Submodule, error) {
 
 	ret := C.git_submodule_lookup(&sub.ptr, repo.ptr, cname)
 	if ret < 0 {
-		return nil, LastError()
+		return nil, MakeGitError(ret)
 	}
 
 	return sub, nil
@@ -94,7 +102,7 @@ func (repo *Repository) ForeachSubmodule(cbk SubmoduleCbk) error {
 
 	ret := C._go_git_visit_submodule(repo.ptr, unsafe.Pointer(&cbk))
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(ret)
 	}
 	return nil
 }
@@ -112,7 +120,7 @@ func (repo *Repository) AddSubmodule(url, path string, use_git_link bool) (*Subm
 
 	ret := C.git_submodule_add_setup(&sub.ptr, repo.ptr, curl, cpath, cbool(use_git_link))
 	if ret < 0 {
-		return nil, LastError()
+		return nil, MakeGitError(ret)
 	}
 	return sub, nil
 }
@@ -123,7 +131,7 @@ func (sub *Submodule) FinalizeAdd() error {
 
 	ret := C.git_submodule_add_finalize(sub.ptr)
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(ret)
 	}
 	return nil
 }
@@ -134,7 +142,7 @@ func (sub *Submodule) AddToIndex(write_index bool) error {
 
 	ret := C.git_submodule_add_to_index(sub.ptr, cbool(write_index))
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(ret)
 	}
 	return nil
 }
@@ -145,7 +153,7 @@ func (sub *Submodule) Save() error {
 
 	ret := C.git_submodule_save(sub.ptr)
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(ret)
 	}
 	return nil
 }
@@ -180,7 +188,7 @@ func (sub *Submodule) SetUrl(url string) error {
 
 	ret := C.git_submodule_set_url(sub.ptr, curl)
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(ret)
 	}
 	return nil
 }
@@ -229,20 +237,17 @@ func (sub *Submodule) SetUpdate(update SubmoduleUpdate) SubmoduleUpdate {
 	return SubmoduleUpdate(o)
 }
 
-func (sub *Submodule) FetchRecurseSubmodules() bool {
-	if 0 == C.git_submodule_fetch_recurse_submodules(sub.ptr) {
-		return false
-	}
-	return true
+func (sub *Submodule) FetchRecurseSubmodules() SubmoduleRecurse {
+	return SubmoduleRecurse(C.git_submodule_fetch_recurse_submodules(sub.ptr))
 }
 
-func (sub *Submodule) SetFetchRecurseSubmodules(v bool) error {
+func (sub *Submodule) SetFetchRecurseSubmodules(recurse SubmoduleRecurse) error {
 	runtime.LockOSThread()
 	defer runtime.UnlockOSThread()
 
-	ret := C.git_submodule_set_fetch_recurse_submodules(sub.ptr, cbool(v))
+	ret := C.git_submodule_set_fetch_recurse_submodules(sub.ptr, C.git_submodule_recurse_t(recurse))
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(C.int(ret))
 	}
 	return nil
 }
@@ -253,7 +258,7 @@ func (sub *Submodule) Init(overwrite bool) error {
 
 	ret := C.git_submodule_init(sub.ptr, cbool(overwrite))
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(ret)
 	}
 	return nil
 }
@@ -264,7 +269,7 @@ func (sub *Submodule) Sync() error {
 
 	ret := C.git_submodule_sync(sub.ptr)
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(ret)
 	}
 	return nil
 }
@@ -277,7 +282,7 @@ func (sub *Submodule) Open() (*Repository, error) {
 
 	ret := C.git_submodule_open(&repo.ptr, sub.ptr)
 	if ret < 0 {
-		return nil, LastError()
+		return nil, MakeGitError(ret)
 	}
 	return repo, nil
 }
@@ -288,7 +293,7 @@ func (sub *Submodule) Reload() error {
 
 	ret := C.git_submodule_reload(sub.ptr)
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(ret)
 	}
 	return nil
 }
@@ -299,7 +304,7 @@ func (repo *Repository) ReloadAllSubmodules() error {
 
 	ret := C.git_submodule_reload_all(repo.ptr)
 	if ret < 0 {
-		return LastError()
+		return MakeGitError(ret)
 	}
 	return nil
 }