diff options
| author | Jeff Carr <[email protected]> | 2025-08-31 12:17:05 -0500 |
|---|---|---|
| committer | Jeff Carr <[email protected]> | 2025-08-31 12:17:05 -0500 |
| commit | 6a205dfa4e3f217e3317509911ddc812a8ef49f6 (patch) | |
| tree | 9f3e340ed0894d98a9df26c522d75f02b7369302 | |
| parent | df3dbcbc7e5bdcf526c109dbdb55a2553d39bb3a (diff) | |
wasn't compiling on the macv0.0.3
| -rw-r--r-- | README.md | 3 | ||||
| -rw-r--r-- | get.go | 8 | ||||
| -rw-r--r-- | get_darwin.go | 2 |
3 files changed, 12 insertions, 1 deletions
@@ -1,3 +1,6 @@ Get() the full hostname for the OS. * only cares about the hostname in DNS +* I wrote this before or not being aware of os.Hostname() + +probably this package should go away @@ -1,9 +1,17 @@ package hostname +import "fmt" + // returns the hostname // hostname is always set to the best effort // error is set if hostname isn't real func Get() (string, error) { hostname, err := osGetHostname() + if hostname == "" { + if err == nil { + err = fmt.Errorf("your machines' hostname is not set") + } + hostname = "unconfigured.hostname" + } return hostname, err } diff --git a/get_darwin.go b/get_darwin.go index 11157c5..d98ce8a 100644 --- a/get_darwin.go +++ b/get_darwin.go @@ -12,7 +12,7 @@ import ( // scutil --set HostName my-mac.example.com func osGetHostname() (string, error) { - return scutil([]string{"-get", "HostName"}) + return scutil([]string{"--get", "HostName"}) } // getDomainName executes the 'domainname' command and returns its output. |
