summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPietro Gagliardi <[email protected]>2014-03-25 07:21:21 -0400
committerPietro Gagliardi <[email protected]>2014-03-25 07:21:21 -0400
commit136f2262fdf20ffe092567a3f7130668f4f1c7a0 (patch)
tree24889cf3015a797a7786467f0e39fd2b2ae01857
parent3c0bcb6d68aa68fd2eb8e646ac0d39c831228ca2 (diff)
More TODOs (and some done TODO elimination).
-rw-r--r--area_windows.go7
-rw-r--r--todo.md2
2 files changed, 3 insertions, 6 deletions
diff --git a/area_windows.go b/area_windows.go
index f784e73..33692fb 100644
--- a/area_windows.go
+++ b/area_windows.go
@@ -139,14 +139,10 @@ func paintArea(s *sysData) {
uintptr(unsafe.Pointer(&ps)))
}
-var (
- _getWindowRect = user32.NewProc("GetWindowRect")
-)
-
func getAreaControlSize(hwnd _HWND) (width int, height int) {
var rect _RECT
- r1, _, err := _getWindowRect.Call(
+ r1, _, err := _getClientRect.Call(
uintptr(hwnd),
uintptr(unsafe.Pointer(&rect)))
if r1 == 0 { // failure
@@ -222,6 +218,7 @@ func scrollArea(hwnd _HWND, wparam _WPARAM, which uintptr) {
uintptr(hwnd),
which,
uintptr(unsafe.Pointer(&si)))
+ // TODO in some cases wine will show a thumb one pixel away from the advance arrow button if going to the end; the values are correct though... weirdness in wine or something I never noticed about Windows?
}
func adjustAreaScrollbars(hwnd _HWND) {
diff --git a/todo.md b/todo.md
index ac96a66..aeaedaf 100644
--- a/todo.md
+++ b/todo.md
@@ -74,11 +74,11 @@ super ultra important things:
- https://developer.apple.com/library/mac/documentation/cocoa/Conceptual/NSScrollViewGuide/Articles/Creating.html#//apple_ref/doc/uid/TP40003226-SW4 the warning about pixel alignment may or may not be heeded, not sure
- frame sizes are a bit of a hack: the preferred size of a NSScrollView is the preferred size of its document view; the frameSize method described on the above link might be better but a real solution is optimal
- make sure the image drawn on an Area looks correct on all platforms (is not cropped incorrectly or blurred)
- - GTK+: requested clip rect seems to be larger than the size of the Area (also larger than the visible portion? TODO)
- when resizing a GTK+ window smaller than a certain size, the controls inside will start clipping in bizarre ways (progress bars/entry lines will just cut off; editable comboboxes will stretch slightly longer than noneditable ones; the horizontal scrollbar in Area will disappear smoothly; etc.)
- the window background of a GTK+ window seems to be... off - I think it has to do with the GtkLayout
- see update 18 March 2014 in README
- resizing seems to be completely and totally broken in the Wayland backend
+- scrolling Areas in wine by clicking in the page scroll area often causes the main thread to lock up; uitask does not
important things:
- make specific wording in documentation consistent (make/create, etc.)