summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPavel Borzenkov <[email protected]>2018-11-18 14:02:17 +0300
committerPavel Borzenkov <[email protected]>2018-11-18 14:02:17 +0300
commite1338aeff04713f53befe44b42323f55fd60338c (patch)
tree52e1f2fbbc29c8a42a882e67a6830b64cc4ead9d
parent38f8eb7c6bf0819f9f2e4e980067994d372a7b76 (diff)
Drop special handling of net.IP type
It's now completely covered by generic TextUnmarshaler case. Signed-off-by: Pavel Borzenkov <[email protected]>
-rw-r--r--scalar.go10
1 files changed, 1 insertions, 9 deletions
diff --git a/scalar.go b/scalar.go
index e4525b3..073392c 100644
--- a/scalar.go
+++ b/scalar.go
@@ -18,7 +18,6 @@ var (
textUnmarshalerType = reflect.TypeOf([]encoding.TextUnmarshaler{}).Elem()
durationType = reflect.TypeOf(time.Duration(0))
mailAddressType = reflect.TypeOf(mail.Address{})
- ipType = reflect.TypeOf(net.IP{})
macType = reflect.TypeOf(net.HardwareAddr{})
)
@@ -80,13 +79,6 @@ func ParseValue(v reflect.Value, s string) error {
}
v.Set(reflect.ValueOf(*addr))
return nil
- case net.IP:
- ip := net.ParseIP(s)
- if ip == nil {
- return fmt.Errorf(`invalid IP address: "%s"`, s)
- }
- v.Set(reflect.ValueOf(ip))
- return nil
case net.HardwareAddr:
ip, err := net.ParseMAC(s)
if err != nil {
@@ -144,7 +136,7 @@ func CanParse(t reflect.Type) bool {
// Check for other special types
switch t {
- case durationType, mailAddressType, ipType, macType:
+ case durationType, mailAddressType, macType:
return true
}