diff options
Diffstat (limited to 'packages/cli/src/ui/components')
| -rw-r--r-- | packages/cli/src/ui/components/InputPrompt.test.tsx | 187 | ||||
| -rw-r--r-- | packages/cli/src/ui/components/InputPrompt.tsx | 23 |
2 files changed, 208 insertions, 2 deletions
diff --git a/packages/cli/src/ui/components/InputPrompt.test.tsx b/packages/cli/src/ui/components/InputPrompt.test.tsx new file mode 100644 index 00000000..d0133e53 --- /dev/null +++ b/packages/cli/src/ui/components/InputPrompt.test.tsx @@ -0,0 +1,187 @@ +/** + * @license + * Copyright 2025 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import { render } from 'ink-testing-library'; +import { InputPrompt, InputPromptProps } from './InputPrompt.js'; +import type { TextBuffer } from './shared/text-buffer.js'; +import { Config } from '@gemini-cli/core'; +import { vi } from 'vitest'; +import { useShellHistory } from '../hooks/useShellHistory.js'; +import { useCompletion } from '../hooks/useCompletion.js'; +import { useInputHistory } from '../hooks/useInputHistory.js'; + +vi.mock('../hooks/useShellHistory.js'); +vi.mock('../hooks/useCompletion.js'); +vi.mock('../hooks/useInputHistory.js'); + +type MockedUseShellHistory = ReturnType<typeof useShellHistory>; +type MockedUseCompletion = ReturnType<typeof useCompletion>; +type MockedUseInputHistory = ReturnType<typeof useInputHistory>; + +describe('InputPrompt', () => { + let props: InputPromptProps; + let mockShellHistory: MockedUseShellHistory; + let mockCompletion: MockedUseCompletion; + let mockInputHistory: MockedUseInputHistory; + let mockBuffer: TextBuffer; + + const mockedUseShellHistory = vi.mocked(useShellHistory); + const mockedUseCompletion = vi.mocked(useCompletion); + const mockedUseInputHistory = vi.mocked(useInputHistory); + + beforeEach(() => { + vi.resetAllMocks(); + + mockBuffer = { + text: '', + cursor: [0, 0], + lines: [''], + setText: vi.fn((newText: string) => { + mockBuffer.text = newText; + mockBuffer.lines = [newText]; + mockBuffer.cursor = [0, newText.length]; + mockBuffer.viewportVisualLines = [newText]; + mockBuffer.allVisualLines = [newText]; + }), + viewportVisualLines: [''], + allVisualLines: [''], + visualCursor: [0, 0], + visualScrollRow: 0, + handleInput: vi.fn(), + move: vi.fn(), + moveToOffset: vi.fn(), + killLineRight: vi.fn(), + killLineLeft: vi.fn(), + openInExternalEditor: vi.fn(), + newline: vi.fn(), + replaceRangeByOffset: vi.fn(), + } as unknown as TextBuffer; + + mockShellHistory = { + addCommandToHistory: vi.fn(), + getPreviousCommand: vi.fn().mockReturnValue(null), + getNextCommand: vi.fn().mockReturnValue(null), + resetHistoryPosition: vi.fn(), + }; + mockedUseShellHistory.mockReturnValue(mockShellHistory); + + mockCompletion = { + suggestions: [], + activeSuggestionIndex: -1, + isLoadingSuggestions: false, + showSuggestions: false, + visibleStartIndex: 0, + navigateUp: vi.fn(), + navigateDown: vi.fn(), + resetCompletionState: vi.fn(), + setActiveSuggestionIndex: vi.fn(), + setShowSuggestions: vi.fn(), + }; + mockedUseCompletion.mockReturnValue(mockCompletion); + + mockInputHistory = { + navigateUp: vi.fn(), + navigateDown: vi.fn(), + handleSubmit: vi.fn(), + }; + mockedUseInputHistory.mockReturnValue(mockInputHistory); + + props = { + buffer: mockBuffer, + onSubmit: vi.fn(), + userMessages: [], + onClearScreen: vi.fn(), + config: { + getProjectRoot: () => '/test/project', + getTargetDir: () => '/test/project/src', + } as unknown as Config, + slashCommands: [], + shellModeActive: false, + setShellModeActive: vi.fn(), + inputWidth: 80, + suggestionsWidth: 80, + focus: true, + }; + }); + + const wait = (ms = 50) => new Promise((resolve) => setTimeout(resolve, ms)); + + it('should call shellHistory.getPreviousCommand on up arrow in shell mode', async () => { + props.shellModeActive = true; + const { stdin, unmount } = render(<InputPrompt {...props} />); + await wait(); + + stdin.write('\u001B[A'); + await wait(); + + expect(mockShellHistory.getPreviousCommand).toHaveBeenCalled(); + unmount(); + }); + + it('should call shellHistory.getNextCommand on down arrow in shell mode', async () => { + props.shellModeActive = true; + const { stdin, unmount } = render(<InputPrompt {...props} />); + await wait(); + + stdin.write('\u001B[B'); + await wait(); + + expect(mockShellHistory.getNextCommand).toHaveBeenCalled(); + unmount(); + }); + + it('should set the buffer text when a shell history command is retrieved', async () => { + props.shellModeActive = true; + vi.mocked(mockShellHistory.getPreviousCommand).mockReturnValue( + 'previous command', + ); + const { stdin, unmount } = render(<InputPrompt {...props} />); + await wait(); + + stdin.write('\u001B[A'); + await wait(); + + expect(mockShellHistory.getPreviousCommand).toHaveBeenCalled(); + expect(props.buffer.setText).toHaveBeenCalledWith('previous command'); + unmount(); + }); + + it('should call shellHistory.addCommandToHistory on submit in shell mode', async () => { + props.shellModeActive = true; + props.buffer.setText('ls -l'); + const { stdin, unmount } = render(<InputPrompt {...props} />); + await wait(); + + stdin.write('\r'); + await wait(); + + expect(mockShellHistory.addCommandToHistory).toHaveBeenCalledWith('ls -l'); + expect(props.onSubmit).toHaveBeenCalledWith('ls -l'); + unmount(); + }); + + it('should NOT call shell history methods when not in shell mode', async () => { + props.buffer.setText('some text'); + const { stdin, unmount } = render(<InputPrompt {...props} />); + await wait(); + + stdin.write('\u001B[A'); // Up arrow + await wait(); + stdin.write('\u001B[B'); // Down arrow + await wait(); + stdin.write('\r'); // Enter + await wait(); + + expect(mockShellHistory.getPreviousCommand).not.toHaveBeenCalled(); + expect(mockShellHistory.getNextCommand).not.toHaveBeenCalled(); + expect(mockShellHistory.addCommandToHistory).not.toHaveBeenCalled(); + + expect(mockInputHistory.navigateUp).toHaveBeenCalled(); + expect(mockInputHistory.navigateDown).toHaveBeenCalled(); + expect(props.onSubmit).toHaveBeenCalledWith('some text'); + unmount(); + }); +}); diff --git a/packages/cli/src/ui/components/InputPrompt.tsx b/packages/cli/src/ui/components/InputPrompt.tsx index 4d2f299b..f9f7ead6 100644 --- a/packages/cli/src/ui/components/InputPrompt.tsx +++ b/packages/cli/src/ui/components/InputPrompt.tsx @@ -13,6 +13,7 @@ import { cpSlice, cpLen, TextBuffer } from './shared/text-buffer.js'; import chalk from 'chalk'; import stringWidth from 'string-width'; import process from 'node:process'; +import { useShellHistory } from '../hooks/useShellHistory.js'; import { useCompletion } from '../hooks/useCompletion.js'; import { isAtCommand, isSlashCommand } from '../utils/commandUtils.js'; import { SlashCommand } from '../hooks/slashCommandProcessor.js'; @@ -58,16 +59,20 @@ export const InputPrompt: React.FC<InputPromptProps> = ({ ); const resetCompletionState = completion.resetCompletionState; + const shellHistory = useShellHistory(config.getProjectRoot()); const handleSubmitAndClear = useCallback( (submittedValue: string) => { + if (shellModeActive) { + shellHistory.addCommandToHistory(submittedValue); + } // Clear the buffer *before* calling onSubmit to prevent potential re-submission // if onSubmit triggers a re-render while the buffer still holds the old value. buffer.setText(''); onSubmit(submittedValue); resetCompletionState(); }, - [onSubmit, buffer, resetCompletionState], + [onSubmit, buffer, resetCompletionState, shellModeActive, shellHistory], ); const customSetTextAndResetCompletionSignal = useCallback( @@ -81,7 +86,7 @@ export const InputPrompt: React.FC<InputPromptProps> = ({ const inputHistory = useInputHistory({ userMessages, onSubmit: handleSubmitAndClear, - isActive: !completion.showSuggestions, + isActive: !completion.showSuggestions && !shellModeActive, currentQuery: buffer.text, onChange: customSetTextAndResetCompletionSignal, }); @@ -304,6 +309,13 @@ export const InputPrompt: React.FC<InputPromptProps> = ({ // Standard arrow navigation within the buffer if (key.upArrow && !completion.showSuggestions) { + if (shellModeActive) { + const prevCommand = shellHistory.getPreviousCommand(); + if (prevCommand !== null) { + buffer.setText(prevCommand); + } + return; + } if ( (buffer.allVisualLines.length === 1 || // Always navigate for single line (buffer.visualCursor[0] === 0 && buffer.visualScrollRow === 0)) && @@ -316,6 +328,13 @@ export const InputPrompt: React.FC<InputPromptProps> = ({ return; } if (key.downArrow && !completion.showSuggestions) { + if (shellModeActive) { + const nextCommand = shellHistory.getNextCommand(); + if (nextCommand !== null) { + buffer.setText(nextCommand); + } + return; + } if ( (buffer.allVisualLines.length === 1 || // Always navigate for single line buffer.visualCursor[0] === buffer.allVisualLines.length - 1) && |
