diff options
| author | Billy Biggs <[email protected]> | 2025-08-03 11:20:55 -0700 |
|---|---|---|
| committer | GitHub <[email protected]> | 2025-08-03 18:20:55 +0000 |
| commit | bedcbb9feb3b4f5fcdd9d64782f3ee1e06376715 (patch) | |
| tree | 112689c4889d8e75bcebda00988340af8eb77910 | |
| parent | 820169ba2e0777ee2bee240f063649cc4b2b107f (diff) | |
Add a setting to disable the version update nag message (#5449)
| -rw-r--r-- | packages/cli/src/config/settings.ts | 3 | ||||
| -rw-r--r-- | packages/cli/src/utils/handleAutoUpdate.test.ts | 8 | ||||
| -rw-r--r-- | packages/cli/src/utils/handleAutoUpdate.ts | 4 |
3 files changed, 15 insertions, 0 deletions
diff --git a/packages/cli/src/config/settings.ts b/packages/cli/src/config/settings.ts index a875ffc1..84f996ba 100644 --- a/packages/cli/src/config/settings.ts +++ b/packages/cli/src/config/settings.ts @@ -111,6 +111,9 @@ export interface Settings { // Setting for disabling auto-update. disableAutoUpdate?: boolean; + // Setting for disabling the update nag message. + disableUpdateNag?: boolean; + memoryDiscoveryMaxDirs?: number; dnsResolutionOrder?: DnsResolutionOrder; } diff --git a/packages/cli/src/utils/handleAutoUpdate.test.ts b/packages/cli/src/utils/handleAutoUpdate.test.ts index f292d0c2..c7c3da67 100644 --- a/packages/cli/src/utils/handleAutoUpdate.test.ts +++ b/packages/cli/src/utils/handleAutoUpdate.test.ts @@ -91,6 +91,14 @@ describe('handleAutoUpdate', () => { expect(mockSpawn).not.toHaveBeenCalled(); }); + it('should do nothing if update nag is disabled', () => { + mockSettings.merged.disableUpdateNag = true; + handleAutoUpdate(mockUpdateInfo, mockSettings, '/root', mockSpawn); + expect(mockGetInstallationInfo).not.toHaveBeenCalled(); + expect(mockUpdateEventEmitter.emit).not.toHaveBeenCalled(); + expect(mockSpawn).not.toHaveBeenCalled(); + }); + it('should emit "update-received" but not update if auto-updates are disabled', () => { mockSettings.merged.disableAutoUpdate = true; mockGetInstallationInfo.mockReturnValue({ diff --git a/packages/cli/src/utils/handleAutoUpdate.ts b/packages/cli/src/utils/handleAutoUpdate.ts index 03a6a8d6..cbcdb2e0 100644 --- a/packages/cli/src/utils/handleAutoUpdate.ts +++ b/packages/cli/src/utils/handleAutoUpdate.ts @@ -22,6 +22,10 @@ export function handleAutoUpdate( return; } + if (settings.merged.disableUpdateNag) { + return; + } + const installationInfo = getInstallationInfo( projectRoot, settings.merged.disableAutoUpdate ?? false, |
