From 343954285090861f84a26e9818e2e946f87b8d1f Mon Sep 17 00:00:00 2001 From: Will Hawkins Date: Mon, 29 Jan 2024 10:15:24 -0500 Subject: [Feature] Be more explicit about which part of the test was unstable When a test did not run to stability, tell the user which part of the test was unstable. Signed-off-by: Will Hawkins --- networkQuality.go | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/networkQuality.go b/networkQuality.go index e1badd9..3cb3979 100644 --- a/networkQuality.go +++ b/networkQuality.go @@ -1047,9 +1047,20 @@ func main() { direction.FormattedResults += fmt.Sprintf("%v:\n", direction.DirectionLabel) if !testRanToStability { + why := "" + if !direction.StableThroughput { + why += "throughput" + } + if !direction.StableResponsiveness { + if len(why) != 0 { + why += ", " + } + why += "responsiveness" + } direction.FormattedResults += utilities.IndentOutput( - "Note: Test did not run to stability, these results are estimates.\n", 1, "\t") + fmt.Sprintf("Note: Test did not run to stability (%v), these results are estimates.\n", why), 1, "\t") } + direction.FormattedResults += utilities.IndentOutput(fmt.Sprintf( "Throughput: %.3f Mbps (%.3f MBps), using %d parallel connections.\n", utilities.ToMbps(lastThroughputRate), @@ -1220,7 +1231,7 @@ func main() { result := rpm.CalculateRpm(unboundedAllSelfRtts, unboundedAllForeignRtts, specParameters.TrimmedMeanPct, specParameters.Percentile) - fmt.Printf("(Unbounded Final RPM Calculation stats):\n%v\n", result.ToString()) + fmt.Printf("Unbounded Final RPM Calculation stats:\n%v\n", result.ToString()) fmt.Printf("Unbounded Final RPM: %.0f (P%d)\n", result.PNRpm, specParameters.Percentile) fmt.Printf("Unbounded Final RPM: %.0f (Single-Sided %v%% Trimmed Mean)\n", @@ -1253,7 +1264,7 @@ func main() { specParameters.TrimmedMeanPct, specParameters.Percentile) if *debugCliFlag { - fmt.Printf("(Final RPM Calculation stats):\n%v\n", result.ToString()) + fmt.Printf("Final RPM Calculation stats:\n%v\n", result.ToString()) } fmt.Printf("Final RPM: %.0f (P%d)\n", result.PNRpm, specParameters.Percentile) -- cgit v1.2.3