From 8247d748bd26be6eb87a978573b0d435e83178a1 Mon Sep 17 00:00:00 2001
From: Jeff Carr <jcarr@wit.com>
Date: Wed, 29 Jan 2025 16:18:04 -0600
Subject: general cleanups

---
 common.go         | 23 +++--------------------
 newRepo.go        |  8 ++++----
 scan.go           |  3 +--
 structs.go        |  4 ++--
 viewAutotypist.go |  1 -
 5 files changed, 10 insertions(+), 29 deletions(-)

diff --git a/common.go b/common.go
index 984a5f2..c90b9af 100644
--- a/common.go
+++ b/common.go
@@ -56,28 +56,9 @@ func (r *RepoList) FindRepo(path string) *RepoRow {
 	return repo
 }
 
-/*
-func (r *RepoList) AllRepos() []*RepoRow {
-	var all []*RepoRow
-	for _, repo := range me.allrepos {
-		all = append(all, repo)
-	}
-	return all
-}
-
-// deprecate this
-func AllRepos() []*RepoRow {
-	var all []*RepoRow
-	for _, repo := range me.allrepos {
-		all = append(all, repo)
-	}
-	return all
-}
-*/
-
 // a human readable state of the current repo
 func (r *RepoRow) State() string {
-	return r.gitState.String()
+	return r.pbState.String()
 }
 
 func (r *RepoRow) Scan() int {
@@ -126,6 +107,7 @@ func (r *RepoRow) LastTag() string {
 	return r.lastTag.String()
 }
 
+/*
 func (r *RepoRow) IsPerfect() bool {
 	if r.gitState.String() == "PERFECT" {
 		return true
@@ -135,6 +117,7 @@ func (r *RepoRow) IsPerfect() bool {
 	}
 	return false
 }
+*/
 
 func (r *RepoRow) Run(cmd []string) cmd.Status {
 	return r.pb.Run(cmd)
diff --git a/newRepo.go b/newRepo.go
index 651259f..b9aabb9 100644
--- a/newRepo.go
+++ b/newRepo.go
@@ -22,7 +22,7 @@ func (r *RepoRow) Hide() {
 	r.develVersion.Hide()
 	r.userVersion.Hide()
 
-	r.gitState.Hide()
+	// r.gitState.Hide()
 	r.pbState.Hide()
 	r.endBox.Hide()
 	r.targetV.Hide()
@@ -39,7 +39,7 @@ func (r *RepoRow) Show() {
 	r.develVersion.Show()
 	r.userVersion.Show()
 
-	r.gitState.Show()
+	// r.gitState.Show()
 	r.pbState.Show()
 	r.endBox.Show()
 	r.targetV.Show()
@@ -56,7 +56,7 @@ func (r *RepoRow) Show2() {
 	r.develVersion.Show()
 	r.userVersion.Show()
 
-	r.gitState.Show()
+	// r.gitState.Show()
 	r.endBox.Show()
 	r.targetV.Show()
 	r.hidden = false
@@ -93,7 +93,7 @@ func (r *RepoList) AddRepo(pb *gitpb.Repo) (*RepoRow, error) {
 	newRepo.masterVersion = r.reposgrid.NewLabel("")
 	newRepo.develVersion = r.reposgrid.NewLabel("")
 	newRepo.userVersion = r.reposgrid.NewLabel("")
-	newRepo.gitState = r.reposgrid.NewLabel("")
+	// newRepo.gitState = r.reposgrid.NewLabel("")
 	newRepo.pbState = r.reposgrid.NewLabel("")
 	newRepo.currentName = r.reposgrid.NewLabel("")
 	newRepo.currentVersion = r.reposgrid.NewLabel("")
diff --git a/scan.go b/scan.go
index e68747f..9249076 100644
--- a/scan.go
+++ b/scan.go
@@ -66,7 +66,6 @@ func (r *RepoRow) NewScan() int {
 	r.masterVersion.SetLabel(pb.GetMasterVersion())
 	r.develVersion.SetLabel(pb.GetDevelVersion())
 	r.userVersion.SetLabel(pb.GetUserVersion())
-	r.gitState.SetLabel(r.Status.CheckGitState())
 	r.pbState.SetLabel(pb.GetState())
 	r.currentName.SetLabel(pb.GetCurrentBranchName())
 	r.currentVersion.SetLabel(pb.GetCurrentBranchVersion())
@@ -74,7 +73,7 @@ func (r *RepoRow) NewScan() int {
 	if r.State() == "merge to main" {
 		r.Hide()
 	}
-	if r.Status.GitState() == "PERFECT" {
+	if pb.GetState() == "PERFECT" {
 		r.Hide()
 	} else {
 		r.Show()
diff --git a/structs.go b/structs.go
index ae3874b..1acac33 100644
--- a/structs.go
+++ b/structs.go
@@ -62,8 +62,8 @@ type RepoRow struct {
 	lastTag        *gui.Node // last tagged version label
 	currentName    *gui.Node // current branch name
 	currentVersion *gui.Node // current branch version
-	gitState       *gui.Node // git state (dirty or not?)
-	pbState        *gui.Node // the state of the protobuf
+	// gitState       *gui.Node // git state (dirty or not?)
+	pbState *gui.Node // the state of the protobuf
 
 	masterVersion *gui.Node // the master branch version
 	develVersion  *gui.Node // the devel branch version
diff --git a/viewAutotypist.go b/viewAutotypist.go
index ae8a615..f391d71 100644
--- a/viewAutotypist.go
+++ b/viewAutotypist.go
@@ -20,7 +20,6 @@ func (rl *RepoList) AutotypistView(parent *gui.Node) {
 	rl.reposgrid.NewLabel("master version")
 	rl.reposgrid.NewLabel("devel version")
 	rl.reposgrid.NewLabel("user version")
-	rl.reposgrid.NewLabel("Status")
 	rl.reposgrid.NewLabel("pb state")
 	rl.reposgrid.NewLabel("Current").SetProgName("CurrentName")
 	rl.reposgrid.NewLabel("Version").SetProgName("CurrentVersion")
-- 
cgit v1.2.3