From c59943a12da4845ccaf7b93ec4b293b19dedea76 Mon Sep 17 00:00:00 2001
From: Will Hawkins <hawkinsw@obs.cr>
Date: Fri, 14 Jul 2023 11:06:08 -0400
Subject: Probe direction is unnused in probe.Probe -- remove it

Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
---
 probe/probe.go | 2 --
 rpm/rpm.go     | 7 +++----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/probe/probe.go b/probe/probe.go
index 3939076..951e65e 100644
--- a/probe/probe.go
+++ b/probe/probe.go
@@ -25,7 +25,6 @@ import (
 
 	"github.com/network-quality/goresponsiveness/debug"
 	"github.com/network-quality/goresponsiveness/extendedstats"
-	"github.com/network-quality/goresponsiveness/lgc"
 	"github.com/network-quality/goresponsiveness/utilities"
 )
 
@@ -80,7 +79,6 @@ func Probe(
 	client *http.Client,
 	probeUrl string,
 	probeHost string, // optional: for use with a test_endpoint
-	probeDirection lgc.LgcDirection,
 	probeType ProbeType,
 	probeId uint,
 	captureExtendedStats bool,
diff --git a/rpm/rpm.go b/rpm/rpm.go
index 6e14418..95e6192 100644
--- a/rpm/rpm.go
+++ b/rpm/rpm.go
@@ -190,7 +190,6 @@ func ResponsivenessProber[BucketType utilities.Number](
 					foreignProbeClient,
 					foreignProbeConfiguration.URL,
 					foreignProbeConfiguration.Host,
-					probeDirection,
 					probe.Foreign,
 					probeCount,
 					captureExtendedStats,
@@ -210,7 +209,7 @@ func ResponsivenessProber[BucketType utilities.Number](
 							fmt.Printf(
 								"(%s) Failed to get a random %s load-generating connection on which to send a probe: %v.\n",
 								debugging.Prefix,
-								utilities.Conditional(probeDirection == lgc.LGC_DOWN, "download", "upload"),
+								probeDirection,
 								err,
 							)
 						}
@@ -229,7 +228,7 @@ func ResponsivenessProber[BucketType utilities.Number](
 						fmt.Printf(
 							"(%s) The selected random %s load-generating connection on which to send a probe was not running.\n",
 							debugging.Prefix,
-							utilities.Conditional(probeDirection == lgc.LGC_DOWN, "download", "upload"),
+							probeDirection,
 						)
 					}
 					return
@@ -239,7 +238,7 @@ func ResponsivenessProber[BucketType utilities.Number](
 					fmt.Printf(
 						"(%s) Selected %s load-generating connection with ID %d to send a self probe with Id %d.\n",
 						debugging.Prefix,
-						utilities.Conditional(probeDirection == lgc.LGC_DOWN, "download", "upload"),
+						probeDirection,
 						(*selfProbeConnection).ClientId(),
 						probeCount,
 					)
-- 
cgit v1.2.3