From 67ae8d8773e97cc93f4a3fc400e77b67dd554ceb Mon Sep 17 00:00:00 2001 From: Jeff Carr Date: Tue, 7 Jan 2025 17:44:23 -0600 Subject: use go generate. also fix verbose Build() flags --- build.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'build.go') diff --git a/build.go b/build.go index 5cf94d6..a5e972a 100644 --- a/build.go +++ b/build.go @@ -30,6 +30,7 @@ func (f *Forge) Install(repo *gitpb.Repo, userFlags []string) error { return f.doBuild(repo, userFlags, "install") } +// userflags are intended for "-v" and "-x" right now func (f *Forge) doBuild(repo *gitpb.Repo, userFlags []string, goWhat string) error { if repo == nil { log.Warn("forge.doBuild repo == nil") @@ -108,7 +109,9 @@ func (f *Forge) doBuild(repo *gitpb.Repo, userFlags []string, goWhat string) err cmd = append(cmd, "-buildmode=plugin", "-o", soname) } } - cmd = append(cmd, "-v") + for _, flag := range userFlags { + cmd = append(cmd, flag) + } // set standard ldflag options now := time.Now() @@ -120,13 +123,6 @@ func (f *Forge) doBuild(repo *gitpb.Repo, userFlags []string, goWhat string) err ldflags += "-X main.GUIVERSION=" + version + "" // todo: git this from the filesystem cmd = append(cmd, "-ldflags", ldflags) - // add any flags from the command line - // this might not actually work - // todo: test this - for _, flag := range userFlags { - cmd = append(cmd, "-ldflags", "-X "+flag) - } - testenv := os.Getenv("GO111MODULE") if testenv == "off" { log.Info("GO111MODULE=off", "f.goWork =", f.IsGoWork(), "f.gosrc =", f.GetGoSrc()) -- cgit v1.2.3