From 51e7cf0ad4888998e5bb40161bc1516c778cf547 Mon Sep 17 00:00:00 2001 From: Matthew Donoughe Date: Fri, 13 Feb 2015 20:44:29 -0500 Subject: use git_signature_free --- repository.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'repository.go') diff --git a/repository.go b/repository.go index 7760c3a..5f51058 100644 --- a/repository.go +++ b/repository.go @@ -211,7 +211,7 @@ func (v *Repository) SetHead(refname string, sig *Signature, msg string) error { defer C.free(unsafe.Pointer(cname)) csig := sig.toC() - defer C.free(unsafe.Pointer(csig)) + defer C.git_signature_free(csig) var cmsg *C.char if msg != "" { @@ -231,7 +231,7 @@ func (v *Repository) SetHead(refname string, sig *Signature, msg string) error { func (v *Repository) SetHeadDetached(id *Oid, sig *Signature, msg string) error { csig := sig.toC() - defer C.free(unsafe.Pointer(csig)) + defer C.git_signature_free(csig) var cmsg *C.char if msg != "" { @@ -254,7 +254,7 @@ func (v *Repository) CreateReference(name string, id *Oid, force bool, sig *Sign defer C.free(unsafe.Pointer(cname)) csig := sig.toC() - defer C.free(unsafe.Pointer(csig)) + defer C.git_signature_free(csig) var cmsg *C.char if msg == "" { @@ -285,7 +285,7 @@ func (v *Repository) CreateSymbolicReference(name, target string, force bool, si defer C.free(unsafe.Pointer(ctarget)) csig := sig.toC() - defer C.free(unsafe.Pointer(csig)) + defer C.git_signature_free(csig) var cmsg *C.char if msg == "" { -- cgit v1.2.3 From c1df2dcdc16cab82e356940658fd83fdd0a3b5b2 Mon Sep 17 00:00:00 2001 From: Fernando Oliveira Date: Thu, 30 Apr 2015 23:16:12 -0300 Subject: Add method to check if repo is detached --- repository.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'repository.go') diff --git a/repository.go b/repository.go index 7fac277..b6c75ef 100644 --- a/repository.go +++ b/repository.go @@ -255,6 +255,20 @@ func (v *Repository) SetHeadDetached(id *Oid, sig *Signature, msg string) error return nil } +func (v *Repository) IsHeadDetached() (bool, error) { + runtime.LockOSThread() + defer runtime.UnlockOSThread() + + ret := C.git_repository_head_detached(v.ptr) + switch ret { + case 1: + return true, nil + case 0: + return false, nil + } + return false, MakeGitError(ret) +} + func (v *Repository) CreateReference(name string, id *Oid, force bool, sig *Signature, msg string) (*Reference, error) { cname := C.CString(name) defer C.free(unsafe.Pointer(cname)) -- cgit v1.2.3 From 4eae20ec279d20948aa5a45e0963ae7c4bcb0712 Mon Sep 17 00:00:00 2001 From: Carlos Martín Nieto Date: Wed, 1 Jul 2015 16:00:17 +0200 Subject: Adjust style --- repository.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'repository.go') diff --git a/repository.go b/repository.go index c271ea6..996e966 100644 --- a/repository.go +++ b/repository.go @@ -260,13 +260,11 @@ func (v *Repository) IsHeadDetached() (bool, error) { defer runtime.UnlockOSThread() ret := C.git_repository_head_detached(v.ptr) - switch ret { - case 1: - return true, nil - case 0: - return false, nil + if ret < 0 { + return false, MakeGitError(ret) } - return false, MakeGitError(ret) + + return ret != 0, nil } func (v *Repository) CreateReference(name string, id *Oid, force bool, sig *Signature, msg string) (*Reference, error) { -- cgit v1.2.3