From c6b94a160eef7546fa61e9e06f50f272d68bab8c Mon Sep 17 00:00:00 2001 From: Mirko Nosenzo Date: Thu, 7 Jul 2016 11:59:37 +0200 Subject: Returning Problems on Remote Rename Problems can be returned as string array on RemoteCollection Rename --- remote.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'remote.go') diff --git a/remote.go b/remote.go index d063c17..cfe6e86 100644 --- a/remote.go +++ b/remote.go @@ -454,9 +454,9 @@ func (o *Remote) PushUrl() string { return C.GoString(C.git_remote_pushurl(o.ptr)) } -func (c *RemoteCollection) Rename(remote, newname string) error { +func (c *RemoteCollection) Rename(remote, newname string) ([]string, error) { cproblems := C.git_strarray{} - + defer freeStrarray(&cproblems) cnewname := C.CString(newname) defer C.free(unsafe.Pointer(cnewname)) cremote := C.CString(remote) @@ -467,10 +467,10 @@ func (c *RemoteCollection) Rename(remote, newname string) error { ret := C.git_remote_rename(&cproblems, c.repo.ptr, cremote, cnewname) if ret < 0 { - return MakeGitError(ret) + problems := makeStringsFromCStrings(cproblems.strings, int(cproblems.count)) + return problems, MakeGitError(ret) } - C.git_strarray_free(&cproblems) - return nil + return []string{}, nil } func (c *RemoteCollection) SetUrl(remote, url string) error { -- cgit v1.2.3