From d43561fbf711896f5ce33f409c6000946416a82b Mon Sep 17 00:00:00 2001 From: Carlos Martín Nieto Date: Wed, 6 Mar 2013 01:43:48 +0100 Subject: Free Git objects via finalizers or manually Provide a manual way of freeing objects, but set finalizers for them in case the user does not want to worry about memory management, which would be useful for commits or trees, which sare typically small. When the objects are freed manually, the finalizer is unset to avoid double-freeing, mimicking what the go runtime does. --- odb.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'odb.go') diff --git a/odb.go b/odb.go index 5688080..6370999 100644 --- a/odb.go +++ b/odb.go @@ -49,7 +49,7 @@ func (v *Odb) Read(oid *Oid) (obj *OdbObject, err error) { return nil, LastError() } - runtime.SetFinalizer(obj, freeOdbObject) + runtime.SetFinalizer(obj, (*OdbObject).Free) return } @@ -57,8 +57,9 @@ type OdbObject struct { ptr *C.git_odb_object } -func freeOdbObject(obj *OdbObject) { - C.git_odb_object_free(obj.ptr) +func (v *OdbObject) Free() { + runtime.SetFinalizer(v, nil) + C.git_odb_object_free(v.ptr) } func (v *OdbObject) Type() int { -- cgit v1.2.3