From dbe032c347b1a1308a4b880e7c5a06d8dfb4d507 Mon Sep 17 00:00:00 2001 From: lhchavez Date: Sun, 5 Sep 2021 13:59:36 -0700 Subject: Make all non-user-creatable structures non-comparable (#802) This change makes all non-user-creatable structures non-comparable. This makes it easier to add changes later that don't introduce breaking changes from the go compatibility guarantees perspective. This, of course, implies that this change _is_ a breaking change, but since these structures are not intended to be created by users (or de-referenced), it should be okay. --- git.go | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'git.go') diff --git a/git.go b/git.go index d672d77..3f51048 100644 --- a/git.go +++ b/git.go @@ -123,6 +123,10 @@ var ( ErrInvalid = errors.New("Invalid state for operation") ) +// doNotCompare is an idiomatic way of making structs non-comparable to avoid +// future field additions to make them non-comparable. +type doNotCompare [0]func() + var pointerHandles *HandleList func init() { -- cgit v1.2.3