From b3f5ec22d33ec8eda33606a6fc1406b8bce824ac Mon Sep 17 00:00:00 2001
From: Eyal Posener <posener@gmail.com>
Date: Thu, 18 May 2017 23:40:02 +0300
Subject: gocomplete: go run should also predict non-main functions

---
 gocomplete/pkgs.go | 26 --------------------------
 1 file changed, 26 deletions(-)

(limited to 'gocomplete/pkgs.go')

diff --git a/gocomplete/pkgs.go b/gocomplete/pkgs.go
index 356a0fa..e3a85d9 100644
--- a/gocomplete/pkgs.go
+++ b/gocomplete/pkgs.go
@@ -4,8 +4,6 @@ import (
 	"bytes"
 	"encoding/json"
 	"os/exec"
-	"path/filepath"
-	"regexp"
 	"strings"
 
 	"github.com/posener/complete"
@@ -13,9 +11,6 @@ import (
 
 const goListFormat = `{"Name": "{{.Name}}", "Path": "{{.Dir}}", "FilesString": "{{.GoFiles}}"}`
 
-// regexp matches a main function
-var reMainFunc = regexp.MustCompile("^main$")
-
 func predictPackages(a complete.Args) (prediction []string) {
 	dir := a.Directory()
 	pkgs := listPackages(dir)
@@ -27,27 +22,6 @@ func predictPackages(a complete.Args) (prediction []string) {
 	return complete.PredictFilesSet(files).Predict(a)
 }
 
-func predictRunnableFiles(a complete.Args) (prediction []string) {
-	dir := a.Directory()
-	pkgs := listPackages(dir)
-
-	files := []string{}
-	for _, p := range pkgs {
-		// filter non main pacakges
-		if p.Name != "main" {
-			continue
-		}
-		for _, f := range p.Files {
-			path := filepath.Join(p.Path, f)
-			if len(functionsInFile(path, reMainFunc)) > 0 {
-				files = append(files, path)
-			}
-		}
-	}
-	complete.Log("FILES: %s", files)
-	return complete.PredictFilesSet(files).Predict(a)
-}
-
 type pack struct {
 	Name        string
 	Path        string
-- 
cgit v1.2.3


From 3555a6948a991f57887ef2fef912b5479cefafcc Mon Sep 17 00:00:00 2001
From: Eyal Posener <posener@gmail.com>
Date: Fri, 19 May 2017 00:11:30 +0300
Subject: gocomplete: better pakcages listing

use go/build package
only read one level of packages, and not all packages
---
 gocomplete/pkgs.go | 72 +++++++++++++++++++++++++++++++++---------------------
 1 file changed, 44 insertions(+), 28 deletions(-)

(limited to 'gocomplete/pkgs.go')

diff --git a/gocomplete/pkgs.go b/gocomplete/pkgs.go
index e3a85d9..e8f5261 100644
--- a/gocomplete/pkgs.go
+++ b/gocomplete/pkgs.go
@@ -1,50 +1,66 @@
 package main
 
 import (
-	"bytes"
-	"encoding/json"
-	"os/exec"
-	"strings"
+	"go/build"
+	"io/ioutil"
+	"os"
+	"path/filepath"
 
 	"github.com/posener/complete"
 )
 
-const goListFormat = `{"Name": "{{.Name}}", "Path": "{{.Dir}}", "FilesString": "{{.GoFiles}}"}`
-
 func predictPackages(a complete.Args) (prediction []string) {
-	dir := a.Directory()
-	pkgs := listPackages(dir)
+	for {
+		prediction = complete.PredictFilesSet(listPackages(a)).Predict(a)
+
+		// if the number of prediction is not 1, we either have many results or
+		// have no results, so we return it.
+		if len(prediction) != 1 {
+			return
+		}
+
+		// if the result is only one item, we might want to recursively check
+		// for more accurate results.
+		if prediction[0] == a.Last {
+			return
+		}
+
+		// only try deeper, if the one item is a directory
+		if stat, err := os.Stat(prediction[0]); err != nil || !stat.IsDir() {
+			return
+		}
 
-	files := make([]string, 0, len(pkgs))
-	for _, p := range pkgs {
-		files = append(files, p.Path)
+		a.Last = prediction[0]
 	}
-	return complete.PredictFilesSet(files).Predict(a)
 }
 
-type pack struct {
-	Name        string
-	Path        string
-	FilesString string
-	Files       []string
-}
+func listPackages(a complete.Args) (dirctories []string) {
+	dir := a.Directory()
+	complete.Log("listing packages in %s", dir)
+	// import current directory
+	pkg, err := build.ImportDir(dir, 0)
+	if err != nil {
+		complete.Log("failed importing directory %s: %s", dir, err)
+		return
+	}
+	dirctories = append(dirctories, pkg.Dir)
 
-func listPackages(dir string) (pkgs []pack) {
-	dir = strings.TrimRight(dir, "/") + "/..."
-	out, err := exec.Command("go", "list", "-f", goListFormat, dir).Output()
+	// import subdirectories
+	files, err := ioutil.ReadDir(dir)
 	if err != nil {
+		complete.Log("failed reading directory %s: %s", dir, err)
 		return
 	}
-	lines := bytes.Split(out, []byte("\n"))
-	for _, line := range lines {
-		var p pack
-		err := json.Unmarshal(line, &p)
+	for _, f := range files {
+		if !f.IsDir() {
+			continue
+		}
+		pkg, err := build.ImportDir(filepath.Join(dir, f.Name()), 0)
 		if err != nil {
+			complete.Log("failed importing subdirectory %s: %s", filepath.Join(dir, f.Name()), err)
 			continue
 		}
-		// parse the FileString from a string "[file1 file2 file3]" to a list of files
-		p.Files = strings.Split(strings.Trim(p.FilesString, "[]"), " ")
-		pkgs = append(pkgs, p)
+		dirctories = append(dirctories, pkg.Dir)
 	}
 	return
 }
-- 
cgit v1.2.3