From 5215b55f46b2b919f50a1df0eaa5886afe4e3b3d Mon Sep 17 00:00:00 2001 From: Dave Collins Date: Thu, 5 Nov 2015 15:09:06 -0600 Subject: Add logic to deal with reflect pkg changes on tip. This commit adds logic to gracefully the internal reflect.Value flag bit changes as of golang commit adf9b30e5594 while maintaining support all the back to Go 1.0. It accomplishes this by adding code to the init time inspection to detect the change and set the flag positions accordingly. While here, also removes a TODO comment since it was already done previously. --- spew/dump.go | 2 -- 1 file changed, 2 deletions(-) (limited to 'spew/dump.go') diff --git a/spew/dump.go b/spew/dump.go index 36a2b6c..a0ff95e 100644 --- a/spew/dump.go +++ b/spew/dump.go @@ -181,8 +181,6 @@ func (d *dumpState) dumpSlice(v reflect.Value) { // Try to use existing uint8 slices and fall back to converting // and copying if that fails. case vt.Kind() == reflect.Uint8: - // TODO(davec): Fix up the disableUnsafe bits... - // We need an addressable interface to convert the type // to a byte slice. However, the reflect package won't // give us an interface on certain things like -- cgit v1.2.3