From aee41a046883fb444204eb2b51bf12a97763919f Mon Sep 17 00:00:00 2001 From: Jeff Carr Date: Fri, 10 Oct 2025 17:02:45 -0500 Subject: NEVER BUILD -dirty .deb packages. causes versioning problems. it's bad idea anyway. I just tried it to see what would happen. it'll randomly upgrade based on the git-hash sort value so it's totally retarded. remove any attempt at the code ever allowing this. Block .deb packages in mirrors incoming/ from being added also. --- doBuild.debian.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'doBuild.debian.go') diff --git a/doBuild.debian.go b/doBuild.debian.go index 701b46b..ddf5af9 100644 --- a/doBuild.debian.go +++ b/doBuild.debian.go @@ -93,7 +93,12 @@ func isDebianRelease() bool { } func shouldBuild(repo *gitpb.Repo) string { - if repo.IsDirty() && !argv.Force { + // NEVER EVER EVER BUILD DIRTY .deb PACKAGES + // versioning with debian will prioritize the 'd' before numbers + // so packages will be randomly upgraded based on the git hash + // just do a commit. Do not 'fix' this. This is a good idea anyway. + // This should be a policy everywhere. + if repo.IsDirty() { return "no" } ver := repo.GetCurrentVersion() @@ -169,7 +174,7 @@ func getOutdir(repo *gitpb.Repo) string { } if repo.CheckDirty() { - return "/home/jcarr/incoming-devel" + return "/home/jcarr/incoming-dirty-junk" } return "/home/jcarr/incoming" -- cgit v1.2.3