From e59c872b3dea9dee8206f990a761e3bfee3a1194 Mon Sep 17 00:00:00 2001 From: Jacob MacDonald Date: Tue, 17 Jun 2025 08:44:54 -0700 Subject: code review followup for compress command (#1097) Followup to https://github.com/google-gemini/gemini-cli/pull/986 --- packages/core/src/core/client.ts | 10 ++++++---- packages/core/src/core/turn.ts | 6 +++--- 2 files changed, 9 insertions(+), 7 deletions(-) (limited to 'packages/core/src') diff --git a/packages/core/src/core/client.ts b/packages/core/src/core/client.ts index 94c598bf..9cc8f328 100644 --- a/packages/core/src/core/client.ts +++ b/packages/core/src/core/client.ts @@ -475,9 +475,11 @@ export class GeminiClient { await cg.countTokens({ model: this.model, contents: newHistory }) ).totalTokens; - return { - originalTokenCount, - newTokenCount, - }; + return originalTokenCount && newTokenCount + ? { + originalTokenCount, + newTokenCount, + } + : null; } } diff --git a/packages/core/src/core/turn.ts b/packages/core/src/core/turn.ts index 4c0a297e..5a8b57e0 100644 --- a/packages/core/src/core/turn.ts +++ b/packages/core/src/core/turn.ts @@ -110,13 +110,13 @@ export type ServerGeminiErrorEvent = { }; export interface ChatCompressionInfo { - originalTokenCount: number | undefined; - newTokenCount: number | undefined; + originalTokenCount: number; + newTokenCount: number; } export type ServerGeminiChatCompressedEvent = { type: GeminiEventType.ChatCompressed; - value: ChatCompressionInfo; + value: ChatCompressionInfo | null; }; export type ServerGeminiUsageMetadataEvent = { -- cgit v1.2.3