From 2998f27f703282359f6389d1c2d8758fc6a14955 Mon Sep 17 00:00:00 2001 From: Richie Foreman Date: Sun, 17 Aug 2025 12:43:21 -0400 Subject: chore(compiler): Enable strict property access TS compiler flag. (#6255) Co-authored-by: Jacob Richman --- .../core/src/telemetry/clearcut-logger/clearcut-logger.ts | 8 ++++---- packages/core/src/telemetry/loggers.ts | 4 ++-- packages/core/src/telemetry/metrics.ts | 14 +++++++------- 3 files changed, 13 insertions(+), 13 deletions(-) (limited to 'packages/core/src/telemetry') diff --git a/packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts b/packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts index 60a31ae7..200a1a0d 100644 --- a/packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts +++ b/packages/core/src/telemetry/clearcut-logger/clearcut-logger.ts @@ -87,11 +87,11 @@ export interface LogRequest { * methods might have in their runtimes. */ function determineSurface(): string { - if (process.env.SURFACE) { - return process.env.SURFACE; - } else if (process.env.GITHUB_SHA) { + if (process.env['SURFACE']) { + return process.env['SURFACE']; + } else if (process.env['GITHUB_SHA']) { return 'GitHub'; - } else if (process.env.TERM_PROGRAM === 'vscode') { + } else if (process.env['TERM_PROGRAM'] === 'vscode') { return detectIde() || DetectedIde.VSCode; } else { return 'SURFACE_NOT_SET'; diff --git a/packages/core/src/telemetry/loggers.ts b/packages/core/src/telemetry/loggers.ts index d7a81203..afc92807 100644 --- a/packages/core/src/telemetry/loggers.ts +++ b/packages/core/src/telemetry/loggers.ts @@ -98,7 +98,7 @@ export function logUserPrompt(config: Config, event: UserPromptEvent): void { }; if (shouldLogUserPrompts(config)) { - attributes.prompt = event.prompt; + attributes['prompt'] = event.prompt; } const logger = logs.getLogger(SERVICE_NAME); @@ -247,7 +247,7 @@ export function logApiResponse(config: Config, event: ApiResponseEvent): void { 'event.timestamp': new Date().toISOString(), }; if (event.response_text) { - attributes.response_text = event.response_text; + attributes['response_text'] = event.response_text; } if (event.error) { attributes['error.message'] = event.error; diff --git a/packages/core/src/telemetry/metrics.ts b/packages/core/src/telemetry/metrics.ts index 1e4509da..a0996410 100644 --- a/packages/core/src/telemetry/metrics.ts +++ b/packages/core/src/telemetry/metrics.ts @@ -197,14 +197,14 @@ export function recordFileOperationMetric( ...getCommonAttributes(config), operation, }; - if (lines !== undefined) attributes.lines = lines; - if (mimetype !== undefined) attributes.mimetype = mimetype; - if (extension !== undefined) attributes.extension = extension; + if (lines !== undefined) attributes['lines'] = lines; + if (mimetype !== undefined) attributes['mimetype'] = mimetype; + if (extension !== undefined) attributes['extension'] = extension; if (diffStat !== undefined) { - attributes.ai_added_lines = diffStat.ai_added_lines; - attributes.ai_removed_lines = diffStat.ai_removed_lines; - attributes.user_added_lines = diffStat.user_added_lines; - attributes.user_removed_lines = diffStat.user_removed_lines; + attributes['ai_added_lines'] = diffStat.ai_added_lines; + attributes['ai_removed_lines'] = diffStat.ai_removed_lines; + attributes['user_added_lines'] = diffStat.user_added_lines; + attributes['user_removed_lines'] = diffStat.user_removed_lines; } fileOperationCounter.add(1, attributes); } -- cgit v1.2.3