From 72fa01f62d01e6cf79b78fc9fed6d042386ace21 Mon Sep 17 00:00:00 2001
From: "N. Taylor Mullen" <ntaylormullen@google.com>
Date: Sun, 8 Jun 2025 18:32:19 -0700
Subject: feat(git): Refactor gitignore handling to use `ignore` library
 instead of `minimatch` (#864)

---
 .../core/src/services/fileDiscoveryService.test.ts | 27 ----------------------
 packages/core/src/services/fileDiscoveryService.ts |  9 --------
 2 files changed, 36 deletions(-)

(limited to 'packages/core/src/services')

diff --git a/packages/core/src/services/fileDiscoveryService.test.ts b/packages/core/src/services/fileDiscoveryService.test.ts
index 2ef83bfa..368f4d23 100644
--- a/packages/core/src/services/fileDiscoveryService.test.ts
+++ b/packages/core/src/services/fileDiscoveryService.test.ts
@@ -140,33 +140,6 @@ describe('FileDiscoveryService', () => {
     });
   });
 
-  describe('getIgnoreInfo', () => {
-    beforeEach(async () => {
-      await service.initialize();
-    });
-
-    it('should return git ignored patterns', () => {
-      const info = service.getIgnoreInfo();
-
-      expect(info.gitIgnored).toEqual(['.git/**', 'node_modules/**']);
-    });
-
-    it('should return empty arrays when git ignore parser is not initialized', async () => {
-      const uninitializedService = new FileDiscoveryService(mockProjectRoot);
-      const info = uninitializedService.getIgnoreInfo();
-
-      expect(info.gitIgnored).toEqual([]);
-    });
-
-    it('should handle git ignore parser returning null patterns', async () => {
-      mockGitIgnoreParser.getIgnoredPatterns.mockReturnValue([] as string[]);
-
-      const info = service.getIgnoreInfo();
-
-      expect(info.gitIgnored).toEqual([]);
-    });
-  });
-
   describe('isGitRepository', () => {
     it('should return true when isGitRepo is explicitly set to true in options', () => {
       const result = service.isGitRepository({ isGitRepo: true });
diff --git a/packages/core/src/services/fileDiscoveryService.ts b/packages/core/src/services/fileDiscoveryService.ts
index 5329507e..3874e752 100644
--- a/packages/core/src/services/fileDiscoveryService.ts
+++ b/packages/core/src/services/fileDiscoveryService.ts
@@ -51,15 +51,6 @@ export class FileDiscoveryService {
     });
   }
 
-  /**
-   * Gets patterns that would be ignored for debugging/transparency
-   */
-  getIgnoreInfo(): { gitIgnored: string[] } {
-    return {
-      gitIgnored: this.gitIgnoreFilter?.getIgnoredPatterns() || [],
-    };
-  }
-
   /**
    * Checks if a single file should be ignored
    */
-- 
cgit v1.2.3