From 4873fce7919b4d74cee183a91fa8a3af58aef993 Mon Sep 17 00:00:00 2001
From: "Anas H. Sulaiman" <mrahs@google.com>
Date: Sat, 14 Jun 2025 10:25:34 -0400
Subject: centralize file filtering in `FileDiscoveryService` (#1039)

---
 packages/core/src/config/config.ts | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

(limited to 'packages/core/src/config/config.ts')

diff --git a/packages/core/src/config/config.ts b/packages/core/src/config/config.ts
index 32c3129d..d841f4b3 100644
--- a/packages/core/src/config/config.ts
+++ b/packages/core/src/config/config.ts
@@ -81,7 +81,6 @@ export interface ConfigParameters {
   approvalMode?: ApprovalMode;
   showMemoryUsage?: boolean;
   contextFileName?: string | string[];
-  geminiIgnorePatterns?: string[];
   accessibility?: AccessibilitySettings;
   telemetry?: boolean;
   telemetryLogUserPromptsEnabled?: boolean;
@@ -119,7 +118,6 @@ export class Config {
   private readonly telemetryLogUserPromptsEnabled: boolean;
   private readonly telemetryOtlpEndpoint: string;
   private readonly geminiClient: GeminiClient;
-  private readonly geminiIgnorePatterns: string[] = [];
   private readonly fileFilteringRespectGitIgnore: boolean;
   private fileDiscoveryService: FileDiscoveryService | null = null;
   private gitService: GitService | undefined = undefined;
@@ -165,9 +163,6 @@ export class Config {
     if (params.contextFileName) {
       setGeminiMdFilename(params.contextFileName);
     }
-    if (params.geminiIgnorePatterns) {
-      this.geminiIgnorePatterns = params.geminiIgnorePatterns;
-    }
 
     this.toolRegistry = createToolRegistry(this);
     this.geminiClient = new GeminiClient(this);
@@ -296,10 +291,6 @@ export class Config {
     return path.join(this.targetDir, GEMINI_DIR);
   }
 
-  getGeminiIgnorePatterns(): string[] {
-    return this.geminiIgnorePatterns;
-  }
-
   getFileFilteringRespectGitIgnore(): boolean {
     return this.fileFilteringRespectGitIgnore;
   }
@@ -320,12 +311,9 @@ export class Config {
     return this.bugCommand;
   }
 
-  async getFileService(): Promise<FileDiscoveryService> {
+  getFileService(): FileDiscoveryService {
     if (!this.fileDiscoveryService) {
       this.fileDiscoveryService = new FileDiscoveryService(this.targetDir);
-      await this.fileDiscoveryService.initialize({
-        respectGitIgnore: this.fileFilteringRespectGitIgnore,
-      });
     }
     return this.fileDiscoveryService;
   }
-- 
cgit v1.2.3