From afc30e314f29e00e462b0f2b11ea63fda31c3c3e Mon Sep 17 00:00:00 2001
From: "N. Taylor Mullen" <ntaylormullen@google.com>
Date: Wed, 4 Jun 2025 00:46:57 -0700
Subject: feat(accessibility): Add option to disable loading phrases (#745)

---
 packages/cli/src/ui/App.test.tsx                    | 5 +++++
 packages/cli/src/ui/App.tsx                         | 6 +++++-
 packages/cli/src/ui/components/LoadingIndicator.tsx | 6 ++++--
 3 files changed, 14 insertions(+), 3 deletions(-)

(limited to 'packages/cli/src/ui')

diff --git a/packages/cli/src/ui/App.test.tsx b/packages/cli/src/ui/App.test.tsx
index cba00b42..0dc4cb79 100644
--- a/packages/cli/src/ui/App.test.tsx
+++ b/packages/cli/src/ui/App.test.tsx
@@ -12,6 +12,7 @@ import {
   MCPServerConfig,
   ApprovalMode,
   ToolRegistry,
+  AccessibilitySettings,
 } from '@gemini-code/core';
 import { LoadedSettings, SettingsFile, Settings } from '../config/settings.js';
 
@@ -35,6 +36,7 @@ interface MockServerConfig {
   approvalMode: ApprovalMode;
   vertexai?: boolean;
   showMemoryUsage?: boolean;
+  accessibility?: AccessibilitySettings;
 
   getApiKey: Mock<() => string>;
   getModel: Mock<() => string>;
@@ -58,6 +60,7 @@ interface MockServerConfig {
   setApprovalMode: Mock<(skip: ApprovalMode) => void>;
   getVertexAI: Mock<() => boolean | undefined>;
   getShowMemoryUsage: Mock<() => boolean>;
+  getAccessibility: Mock<() => AccessibilitySettings>;
 }
 
 // Mock @gemini-code/core and its Config class
@@ -87,6 +90,7 @@ vi.mock('@gemini-code/core', async (importOriginal) => {
         approvalMode: opts.approvalMode ?? ApprovalMode.DEFAULT,
         vertexai: opts.vertexai,
         showMemoryUsage: opts.showMemoryUsage ?? false,
+        accessibility: opts.accessibility ?? {},
 
         getApiKey: vi.fn(() => opts.apiKey || 'test-key'),
         getModel: vi.fn(() => opts.model || 'test-model-in-mock-factory'),
@@ -112,6 +116,7 @@ vi.mock('@gemini-code/core', async (importOriginal) => {
         setApprovalMode: vi.fn(),
         getVertexAI: vi.fn(() => opts.vertexai),
         getShowMemoryUsage: vi.fn(() => opts.showMemoryUsage ?? false),
+        getAccessibility: vi.fn(() => opts.accessibility ?? {}),
       };
     });
   return {
diff --git a/packages/cli/src/ui/App.tsx b/packages/cli/src/ui/App.tsx
index ddaf2f02..c463afdb 100644
--- a/packages/cli/src/ui/App.tsx
+++ b/packages/cli/src/ui/App.tsx
@@ -399,7 +399,11 @@ export const App = ({
           ) : (
             <>
               <LoadingIndicator
-                currentLoadingPhrase={currentLoadingPhrase}
+                currentLoadingPhrase={
+                  config.getAccessibility()?.disableLoadingPhrases
+                    ? undefined
+                    : currentLoadingPhrase
+                }
                 elapsedTime={elapsedTime}
               />
               <Box
diff --git a/packages/cli/src/ui/components/LoadingIndicator.tsx b/packages/cli/src/ui/components/LoadingIndicator.tsx
index 64059d53..6ff4dac8 100644
--- a/packages/cli/src/ui/components/LoadingIndicator.tsx
+++ b/packages/cli/src/ui/components/LoadingIndicator.tsx
@@ -12,7 +12,7 @@ import { StreamingState } from '../types.js';
 import { GeminiRespondingSpinner } from './GeminiRespondingSpinner.js';
 
 interface LoadingIndicatorProps {
-  currentLoadingPhrase: string;
+  currentLoadingPhrase?: string;
   elapsedTime: number;
   rightContent?: React.ReactNode;
 }
@@ -37,7 +37,9 @@ export const LoadingIndicator: React.FC<LoadingIndicatorProps> = ({
           }
         />
       </Box>
-      <Text color={Colors.AccentPurple}>{currentLoadingPhrase}</Text>
+      {currentLoadingPhrase && (
+        <Text color={Colors.AccentPurple}>{currentLoadingPhrase}</Text>
+      )}
       <Text color={Colors.SubtleComment}>
         {streamingState === StreamingState.WaitingForConfirmation
           ? ''
-- 
cgit v1.2.3