From c8cf954e6ef8b360b0c7880ca4d29a12eb1ec7c8 Mon Sep 17 00:00:00 2001 From: Pascal Birchler Date: Wed, 9 Jul 2025 00:10:36 +0200 Subject: fix(auth): do not blindly default to API key auth (#3235) Co-authored-by: matt korwel Co-authored-by: N. Taylor Mullen --- packages/cli/src/ui/components/AuthDialog.tsx | 41 ++++++++++++++++++--------- 1 file changed, 27 insertions(+), 14 deletions(-) (limited to 'packages/cli/src/ui/components/AuthDialog.tsx') diff --git a/packages/cli/src/ui/components/AuthDialog.tsx b/packages/cli/src/ui/components/AuthDialog.tsx index a33e284d..d46feb0b 100644 --- a/packages/cli/src/ui/components/AuthDialog.tsx +++ b/packages/cli/src/ui/components/AuthDialog.tsx @@ -24,7 +24,11 @@ export function AuthDialog({ initialErrorMessage, }: AuthDialogProps): React.JSX.Element { const [errorMessage, setErrorMessage] = useState( - initialErrorMessage || null, + initialErrorMessage + ? initialErrorMessage + : process.env.GEMINI_API_KEY + ? 'Existing API key detected (GEMINI_API_KEY). Select "Gemini API Key" option to use it.' + : null, ); const items = [ { @@ -46,13 +50,17 @@ export function AuthDialog({ { label: 'Vertex AI', value: AuthType.USE_VERTEX_AI }, ]; - let initialAuthIndex = items.findIndex( - (item) => item.value === settings.merged.selectedAuthType, - ); + const initialAuthIndex = items.findIndex((item) => { + if (settings.merged.selectedAuthType) { + return item.value === settings.merged.selectedAuthType; + } - if (initialAuthIndex === -1) { - initialAuthIndex = 0; - } + if (process.env.GEMINI_API_KEY) { + return item.value === AuthType.USE_GEMINI; + } + + return item.value === AuthType.LOGIN_WITH_GOOGLE; + }); const handleAuthSelect = (authMethod: AuthType) => { const error = validateAuthMethod(authMethod); @@ -90,13 +98,18 @@ export function AuthDialog({ padding={1} width="100%" > - Select Auth Method - + Get started + + How would you like to authenticate for this project? + + + + {errorMessage && ( {errorMessage} -- cgit v1.2.3