From 63f864cdd79a0357ec1e0474586fb00a0ec7d91b Mon Sep 17 00:00:00 2001 From: Taylor Mullen Date: Sun, 20 Apr 2025 22:10:23 -0400 Subject: Fix read-file from exploding with path not found error. - There were a few hiccups here. Somehow 2.5-flash wasn't actually abiding by our tool schema. Instead it was inferring `path`. To semi-combat this I've renamed `file_path` -> `path`. - We weren't elevating errors that were created via schema validation. Instead both the `glob` and `read-file.ts` now surface this. - In error scenarios (like failing schema) we were improperly surfacing these as success cases because we were overriding tool status. --- packages/cli/src/tools/read-file.tool.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'packages/cli/src/tools') diff --git a/packages/cli/src/tools/read-file.tool.ts b/packages/cli/src/tools/read-file.tool.ts index bbf9eafb..206267be 100644 --- a/packages/cli/src/tools/read-file.tool.ts +++ b/packages/cli/src/tools/read-file.tool.ts @@ -38,8 +38,7 @@ export class ReadFileTool extends BaseTool { * Delegates validation to the core logic */ validateToolParams(_params: ReadFileToolParams): string | null { - // Currently allowing any path. Add validation if needed. - return null; + return this.coreLogic.validateToolParams(_params); } /** @@ -62,7 +61,7 @@ export class ReadFileTool extends BaseTool { /** * Delegates execution to the core logic */ - async execute(params: ReadFileToolParams): Promise { + execute(params: ReadFileToolParams): Promise { return this.coreLogic.execute(params); } } -- cgit v1.2.3